[#30307] - [4.0] When there is no filter form the admin list view should not crash
- Fixed in Code Base
- 31 Aug 2020
- Medium
- Build: 4.0-dev
- # 30307
- Diff
- Digital-Peak:j4/fix/no/filter/form
User tests: Successful: Unsuccessful:
Summary of Changes
When an extension has no filter form file then the list view throws an Exception, which should not be the case as the form name is guessed only. This pr catches that exception and executes normally. Additionally I made the code a bit easier to read :-)
This issue can't be reproduced with core as I have it on one of my extensions. So merge by review @wilsonge.
Testing Instructions
None with core possible without hacking to man files.
Actual result BEFORE applying this Pull Request
No error is thrown when no filter form file is available.
Expected result AFTER applying this Pull Request
Page loads.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Renamed \administrator\components\com_content\forms\filter_articles.xml
Before PR:
0 Form::loadForm could not load file
After PR:
0 Call to a member function removeField() on null
Is this the expected behavior?
Yes, because it expects a filter form. What you can do is to remove the code in the view which loads the filter bar.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30307.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30307.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-31 15:37:22 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
?
|
||
Merging thanks
I have tested this item✅ successfully on 583fd4c
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30307.