[#30282] - Global configuration wipes out settings for a given component
- Closed
- 16 Oct 2020
- Medium
- Build: staging
- # 30282
Steps to reproduce the issue
- Open your favourite database editor
- Open the table
#__extensions - Filter the list on
name = 'com_users' - Copy-paste the content of the
paramscolumn into your favourite editor - Checkout the
4.0-devbranch - Run
npm install - Login to backend
- Go to Users -> Manage
- Click on the Options
- Open tab
Password options - Set Minimum Length to 4 by typing in 4 into the field
- Click on Save
- See the Success message and the Minimum Length changed back to 12
- Go back to your database editor
- Reload the table
- See that the
paramscolumn is empty. Your settings have been wiped.
Expected result
An error that the minimum length must be at least 12
Actual result
A success message and my settings wiped
System information (as much as possible)
Joomla 4.0 git checkout
Additional comments
This is caused by several issues:
On this line it false states that the messages are enqueued by the validate method. The validate method doesn't queue messages.
On this line we set the redirect but we don't actually perform the redirect so it continues saving the result. The result is actually false. This causes the data wiping.
joomla-cms-bot
- | Labels |
Added:
J4 Issue
?
?
|
||
Ah I see the problem
<field
name="minimum_length"
type="number"
label="COM_USERS_CONFIG_FIELD_MINIMUM_PASSWORD_LENGTH"
min="8"
step="1"
default="12"
validate="number"
/>
The min of 8 only applies to the up/down arrows on the field and you can still type 4
The validation is only that its a number and not that it 8 or more
The same error happens on other fields which have a maximum value and you type a value greater than that
This was just a "lucky" find. The real issue is the failing of the form validation causing the system to store an empty value in the params field. Combined with a success message, a user may think that all is dandy.
I am in doubt about accessibility of this kind of input field. Why not use the dropdowns?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30282.
I am in doubt about accessibility of this kind of input field. Why not use the dropdowns?
It's a native HTML5 element, nothing we invented ourself. I wouldn't expect accessibility issues with that by itself.
On this line we set the redirect but we don't actually perform the redirect so it continues saving the result. The result is actually false. This causes the data wiping.
@roland-d Can it be there is just a return false; missing after the $this->setRedirect(...);? I've had a similar issue at another place in past and fixed it that way.
P.S.: Same at other places, e.g. if we catch an exception when writing fails.
@richard67 As far as I saw, we need to redirect at this point but just adding that is not enough because there are no messages queued.
Use $model->getError() to get the message. Although there are some other issues like not storing/loading values from user state after validation fails.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-16 08:11:19 |
| Closed_By | ⇒ | SharkyKZ | |
| Labels |
Added:
?
Removed: ? |
||
wilsonge
- | Labels |
Removed:
?
|
||
Why would that be expected?