NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
4 Aug 2020

Pull Request for Issue #29989

Summary of Changes

Changes icons to white on save/cancel buttons.

Testing Instructions

apply pr
run npm ci or download prebuilt package.
go to administrator/index.php?option=com_content&view=article&layout=edit&id=2
click on "images & links"
verify save/cancel icons are white
install "blog sample data"
log into front end as super admin.
go to index.php?option=com_config&view=templates&Itemid=112
verify save/cancel buttons have white icons

Actual result BEFORE applying this Pull Request

image
image

Expected result AFTER applying this Pull Request

image

image

Documentation Changes Required

none

avatar N6REJ N6REJ - open - 4 Aug 2020
avatar N6REJ N6REJ - change - 4 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Aug 2020
Category Administration Templates (admin) NPM Change Front End com_config
avatar N6REJ N6REJ - change - 4 Aug 2020
Title
save/cancel button icon color
[4.0] save/cancel button icon color
avatar N6REJ N6REJ - edited - 4 Aug 2020
avatar N6REJ N6REJ - change - 4 Aug 2020
Labels Added: NPM Resource Changed ?
avatar infograf768
infograf768 - comment - 5 Aug 2020

This is not enough for article edit (frontend):

Screen Shot 2020-08-05 at 13 10 15

avatar infograf768
infograf768 - comment - 5 Aug 2020

It is also not enough for module edit (frontend)

Screen Shot 2020-08-05 at 13 16 23

Same for site settings

Screen Shot 2020-08-05 at 13 21 39

avatar N6REJ
N6REJ - comment - 5 Aug 2020

in variables.scss how can I tell it that $success and $danger are default values only.
compiler doesn't like !default

$theme-colors: map-merge((
  primary:                         $base-color, //used only in bootstrap, please use $atum-bg-dark
  secondary:                       $gray-700, //used for btn-secondary
  success:                         $green,
  info:                            $light-blue,
  warning:                         $yellow,
  danger:                          $red,
  light:                           $gray-100, //used in bootstrap
  dark:                            $gray-900,  //used in bootstrap and for table-border
  atum-link-color:                 $light-blue,
  atum-text-dark:                  $gray-700,
  atum-bg-dark:                    $base-color, //standard background color
  action:                          $base-color,
  error:                           $red-dark,
  alert-success:                   $green-dark
), $theme-colors);

the problem is being caused by this overriding form.scss

.icon-publish,
.fa-check {
  color: theme-color("success");

  .dropdown-status-group & {
    color: inherit;
  }
}

.icon-unpublish,
.fa-times {
  color: theme-color("danger");

  .dropdown-status-group & {
    color: inherit;
  }
}
avatar infograf768
infograf768 - comment - 6 Aug 2020

Why not just deleting these classes in /templates/cassiopeia/scss/blocks/_icons.scss ?
tested here and looks fine.

avatar N6REJ
N6REJ - comment - 6 Aug 2020

Why not just deleting these classes in /templates/cassiopeia/scss/blocks/_icons.scss ?
tested here and looks fine.

I'll go hang my head in shame now... I guess I'm so used to things being in J! for reasons I don't understand that that thought never crossed my mind.

avatar joomla-cms-bot joomla-cms-bot - change - 7 Aug 2020
Category Administration Templates (admin) NPM Change Front End com_config Administration Templates (admin) NPM Change Front End com_config Templates (site)
avatar N6REJ
N6REJ - comment - 7 Aug 2020

@infograf768 I think it would be more consistent to go ahead and use variables so that it can be easily changed ( like by the casseopia group ) as needed.

avatar infograf768
infograf768 - comment - 7 Aug 2020
avatar chmst
chmst - comment - 7 Aug 2020

@helvecio - frontend template design?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30278.

avatar N6REJ
N6REJ - comment - 7 Aug 2020

@infograf768 I don't understand what needs to be fixed.

avatar N6REJ
N6REJ - comment - 8 Aug 2020

@infograf768 it was following the 2 space rule because its inside another {} but I changed storm to
image
and ran reformatter.
Couldn't change it any other way.

avatar infograf768
infograf768 - comment - 9 Aug 2020

Sorry to say but you made it worse

avatar infograf768
infograf768 - comment - 9 Aug 2020

Here is a corrected one.

form.txt

avatar N6REJ
N6REJ - comment - 9 Aug 2020

@infograf768 according to storm nothing was changed but I applied/saved/pushed it anyway.

Maybe someday I can actually get someone to help me setup storm properly. I've gotten tired of asking.

avatar infograf768
infograf768 - comment - 9 Aug 2020

Forget storm please. I modified the file for you. This will trigger drone again.

FYI, this is what drone error displayed for scss before I corrected your file.
Screen Shot 2020-08-09 at 10 36 10

avatar infograf768
infograf768 - comment - 9 Aug 2020

And this is what it displays after
Screen Shot 2020-08-09 at 10 45 52

avatar N6REJ
N6REJ - comment - 9 Aug 2020

@infograf768 what ide if any are you using?

avatar infograf768
infograf768 - comment - 9 Aug 2020

I use eclipse, but it is not set to show indentations errors. I just code manually.

avatar N6REJ
N6REJ - comment - 9 Aug 2020

ok, I'm doing my best is all I can say. Glad to see drone is happy now.. ty for the corrected file.

avatar infograf768
infograf768 - comment - 9 Aug 2020

@N6REJ

I suggest you change back your phpstorm to the original settings for tabs as it would kill further PRs. There was only one change to do manually before you modified.

Now, remains one change to do for Save & Close when editing modules as the icon is white on white.

We get
Screen Shot 2020-08-09 at 11 28 19

I guess we should have
Screen Shot 2020-08-09 at 11 28 41

i.e.
change

			<button type="button" class="btn btn-secondary" data-submit-task="modules.save">
				<span class="fas fa-check" aria-hidden="true"></span>
				<?php echo Text::_('JSAVE'); ?>
			</button>

to

			<button type="button" class="btn btn-primary" data-submit-task="modules.save">
				<span class="fas fa-check" aria-hidden="true"></span>
				<?php echo Text::_('JSAVE'); ?>
			</button>
avatar sandewt
sandewt - comment - 9 Aug 2020

install "blog sample data"

@N6REJ How to install this?

Note: I have tested the following link in the fontend successfully: /index.php/test?view=form&layout=edit&a_id=1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30278.

avatar infograf768
infograf768 - comment - 9 Aug 2020

@sandewt
Clean joomla installation.
Then
Screen Shot 2020-08-09 at 12 02 57

patch and run npm ci, display various stuff in frontend

avatar sandewt
sandewt - comment - 9 Aug 2020

@infograf768 thanks

avatar sandewt sandewt - test_item - 9 Aug 2020 - Tested successfully
avatar sandewt
sandewt - comment - 9 Aug 2020

I have tested this item successfully on b97b9cf

Joomla! 4.0.0-beta4-dev+pr.30278 Development [ Mañana ] 29-July-2020 18:21 GMT


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30278.

avatar infograf768
infograf768 - comment - 9 Aug 2020

@sandewt
can’t be ok until #30278 (comment) is solved. 😉

avatar sandewt
sandewt - comment - 9 Aug 2020

@infograf768

I'm waiting 😃

avatar N6REJ
N6REJ - comment - 9 Aug 2020

@infograf768 is this correct for scss?
image

php
image

avatar N6REJ
N6REJ - comment - 9 Aug 2020

There was only one change to do manually before you modified.

Thats just it, it wouldn't do it. I would hit enter and it would put the 4, which was 2+2

avatar N6REJ
N6REJ - comment - 9 Aug 2020

@infograf768 I made the change you suggested but not sure how to test as I can't find the area you showed the error in.

avatar infograf768
infograf768 - comment - 10 Aug 2020

@N6REJ

@infograf768 I made the change you suggested but not sure how to test as I can't find the area you showed the error in.

Frontend module editing.

avatar infograf768
infograf768 - comment - 10 Aug 2020

@sandewt
now you can test fully.

avatar infograf768 infograf768 - test_item - 10 Aug 2020 - Tested successfully
avatar infograf768
infograf768 - comment - 10 Aug 2020

I have tested this item successfully on 0a47873


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30278.

avatar sandewt sandewt - test_item - 10 Aug 2020 - Tested successfully
avatar sandewt
sandewt - comment - 10 Aug 2020

I have tested this item successfully on 0a47873

Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT

Joomla_4.0.0-beta4-dev+pr.30278-Development-Update_Package.zip


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30278.
avatar infograf768 infograf768 - change - 10 Aug 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 10 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30278.

avatar sandewt
sandewt - comment - 10 Aug 2020

Images by test results:

30278-1
30278-2
30278-3

avatar infograf768 infograf768 - close - 10 Aug 2020
avatar infograf768 infograf768 - merge - 10 Aug 2020
avatar infograf768 infograf768 - change - 10 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-10 07:53:00
Closed_By infograf768
Labels Added: ?
avatar infograf768
infograf768 - comment - 10 Aug 2020

Tks

Add a Comment

Login with GitHub to post a comment