User tests: Successful: Unsuccessful:
Pull Request for Issue #29989
Changes icons to white on save/cancel buttons.
apply pr
run npm ci or download prebuilt package.
go to administrator/index.php?option=com_content&view=article&layout=edit&id=2
click on "images & links"
verify save/cancel icons are white
install "blog sample data"
log into front end as super admin.
go to index.php?option=com_config&view=templates&Itemid=112
verify save/cancel buttons have white icons
none
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) NPM Change Front End com_config |
Title |
|
Labels |
Added:
NPM Resource Changed
?
|
in variables.scss how can I tell it that $success and $danger are default values only.
compiler doesn't like !default
$theme-colors: map-merge((
primary: $base-color, //used only in bootstrap, please use $atum-bg-dark
secondary: $gray-700, //used for btn-secondary
success: $green,
info: $light-blue,
warning: $yellow,
danger: $red,
light: $gray-100, //used in bootstrap
dark: $gray-900, //used in bootstrap and for table-border
atum-link-color: $light-blue,
atum-text-dark: $gray-700,
atum-bg-dark: $base-color, //standard background color
action: $base-color,
error: $red-dark,
alert-success: $green-dark
), $theme-colors);
the problem is being caused by this overriding form.scss
.icon-publish,
.fa-check {
color: theme-color("success");
.dropdown-status-group & {
color: inherit;
}
}
.icon-unpublish,
.fa-times {
color: theme-color("danger");
.dropdown-status-group & {
color: inherit;
}
}
Why not just deleting these classes in /templates/cassiopeia/scss/blocks/_icons.scss
?
tested here and looks fine.
Why not just deleting these classes in
/templates/cassiopeia/scss/blocks/_icons.scss
?
tested here and looks fine.
I'll go hang my head in shame now... I guess I'm so used to things being in J! for reasons I don't understand that that thought never crossed my mind.
Category | Administration Templates (admin) NPM Change Front End com_config | ⇒ | Administration Templates (admin) NPM Change Front End com_config Templates (site) |
@infograf768 I think it would be more consistent to go ahead and use variables so that it can be easily changed ( like by the casseopia group ) as needed.
Needs scss correction https://ci.joomla.org/joomla/joomla-cms/34526/1/24
@helvecio - frontend template design?
@infograf768 I don't understand what needs to be fixed.
@infograf768 it was following the 2 space rule because its inside another {} but I changed storm to
and ran reformatter.
Couldn't change it any other way.
Sorry to say but you made it worse
@infograf768 according to storm nothing was changed but I applied/saved/pushed it anyway.
Maybe someday I can actually get someone to help me setup storm properly. I've gotten tired of asking.
@infograf768 what ide if any are you using?
I use eclipse, but it is not set to show indentations errors. I just code manually.
ok, I'm doing my best is all I can say. Glad to see drone is happy now.. ty for the corrected file.
I suggest you change back your phpstorm to the original settings for tabs as it would kill further PRs. There was only one change to do manually before you modified.
Now, remains one change to do for Save & Close
when editing modules as the icon is white on white.
i.e.
change
<button type="button" class="btn btn-secondary" data-submit-task="modules.save">
<span class="fas fa-check" aria-hidden="true"></span>
<?php echo Text::_('JSAVE'); ?>
</button>
to
<button type="button" class="btn btn-primary" data-submit-task="modules.save">
<span class="fas fa-check" aria-hidden="true"></span>
<?php echo Text::_('JSAVE'); ?>
</button>
install "blog sample data"
@N6REJ How to install this?
Note: I have tested the following link in the fontend successfully: /index.php/test?view=form&layout=edit&a_id=1
@infograf768 thanks
I have tested this item
Joomla! 4.0.0-beta4-dev+pr.30278 Development [ Mañana ] 29-July-2020 18:21 GMT
@sandewt
can’t be ok until #30278 (comment) is solved.
I'm waiting
@infograf768 is this correct for scss?
There was only one change to do manually before you modified.
Thats just it, it wouldn't do it. I would hit enter and it would put the 4, which was 2+2
@infograf768 I made the change you suggested but not sure how to test as I can't find the area you showed the error in.
@infograf768 I made the change you suggested but not sure how to test as I can't find the area you showed the error in.
Frontend module editing.
I have tested this item
I have tested this item
Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT
Joomla_4.0.0-beta4-dev+pr.30278-Development-Update_Package.zip
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-10 07:53:00 |
Closed_By | ⇒ | infograf768 | |
Labels |
Added:
?
|
Tks
This is not enough for article edit (frontend):