[#30268] - [4.0] FieldsHelper: Choose a first available category correctly
- Fixed in Code Base
- 1 Sep 2020
- Medium
- Build: 4.0-dev
- # 30268
- Diff
- Fedik:fix-23036
User tests: Successful: Unsuccessful:
Try to fix release blocker #23036 .
Summary of Changes
This is correcting a way to retrieve a first category in list
Testing Instructions
Apply patch, and create a field assigned to specific category.
Then create a new Article to this category and make sure the field is there.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Documentation Changes Required
nope
ping @wilsonge
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
| Labels |
Added:
?
|
||
I have tested this item
If it works before and works after applying the patch it is not clear what to look for as a test result.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30268.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30268.
Do we need this same code in the other places we have this (WorkflowBehaviorTrait and ArticleModel)?
Good question, I did not seen it there,
if it use
$xml->loadHTML($formField->__get('input'));
$options = $xml->getElementsByTagName('option');Then yes, it also need to be changed.
Do not merge it for now, I will check that also
| Status | Ready to Commit | ⇒ | Pending |
| Category | Administration com_fields | ⇒ | Administration com_content com_fields Libraries |
I have updated WorkflowBehaviorTrait and ArticleModel. Please re-check
I just have no idea where to test WorkflowBehaviorTrait.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30268.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-01 07:05:19 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
(Merged as there was two good changes in the main patch and one good test on rolling the same thing out to two other places)
I have tested this item✅ successfully on a5eef98
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30268.