Feeling Lucky
?
?
?
[#30262] - [4.0] [a11y] add sr-only text to first column of table head
- Fixed in Code Base
- 16 Oct 2020
- Medium
- Build: 4.0-dev
- # 30262
- Diff
- hans2103:feature/table-head-for-large-table
User tests: Successful: Unsuccessful:
Pull Request for Issue #30214 .
Summary of Changes
This PR has influence on the installation of Joomla.
Once you get on _ Install Additional Languages_ it will add a screen reader only text to the table head of the first column of the table shown.
Testing Instructions
- Install Joomla 4
- Press Install Additional Languages
- Inspect element on the first column of the table.
- Apply the PR and inspect the element again.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings |
| Title |
|
||||||
hans2103
- comment
- 2 Aug 2020
While I obviously disagree with the need for this it is not correct markup.
If it is a table heading then it must be a th and not a td. You can also not have a scope on a td
thank you for your feedback. I will update my PR.
| Labels |
Added:
?
?
|
||
brianteeman
- comment
- 2 Aug 2020
The code now does what it says it will do
zwiastunsw
- comment
- 4 Aug 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30262.
armenos
- comment
- 4 Aug 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30262.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 4 Aug 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30262.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-10-16 11:23:10 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
While I obviously disagree with the need for this it is not correct markup.
If it is a table heading then it must be a th and not a td. You can also not have a scope on a td