? Success

User tests: Successful: Unsuccessful:

avatar compojoom compojoom - open - 2 Feb 2014
avatar brianteeman brianteeman - change - 21 Aug 2014
Status New Pending
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar n9iels
n9iels - comment - 28 Feb 2015

@test I can't reproduce the bug. When I edit my config.xml, I can't save the file without fill it out. When I go to another tab, I also get a message


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3026.
avatar n9iels n9iels - test_item - 28 Feb 2015 - Tested unsuccessfully
avatar pe7er
pe7er - comment - 28 Feb 2015

Could you please add a step-by-step testing procedure, including screen shots with arrows & annotations?
That way the issue + your patch will be easier to test.
Could you please respond within 30 days, otherwise this issue will be closed.
Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3026.
avatar pe7er pe7er - test_item - 28 Feb 2015 - Not tested
avatar compojoom
compojoom - comment - 14 Mar 2015

The reproduce steps that I've posted on joomlacode are still correct for Cmandrill & cmc.
However if you want to reproduce this with com_content, since we now have js validation you should modify the view files & remove the validation there.

To make things easier, let's test with CMandrill.
First download CMandrill from:
https://compojoom.com/downloads/official-releases-stable/mandrill

then install it. Now go to components -> CMandrill options. Go to the permissions tab and try to change any permission. Save. The page will refresh without any error message and the permissions that you've applied shouldn't be saved.

Now apply the patch and try to save the config again. This time you'll see the error message.

avatar compojoom
compojoom - comment - 14 Mar 2015

Okay, the above description is wrong. We have now javascript validation and running into the issue is a little difficult.
First we need to disable the javascript validation. Go to:
administrator\components\com_config\view\component\tmpl\default.php
comment out line 23,24 & 27. At the end your code should look like this:

Joomla.submitbutton = function(task)
    {
//      if (task === "config.cancel.component" || document.formvalidator.isValid(document.getElementById("component-form")))
//      {
            Joomla.submitform(task, document.getElementById("component-form"));
//      }
    };

After that test it with CMandrill:
First download CMandrill from:
https://compojoom.com/downloads/official-releases-stable/mandrill

then install it. Now go to components -> CMandrill options. Go to the permissions tab and try to change any permission. Save. The page will refresh without any error message and the permissions that you've applied shouldn't be saved.

Now apply the patch and try to save the config again. This time you'll see the error message.

avatar yvesh yvesh - test_item - 14 Mar 2015 - Tested successfully
avatar compojoom compojoom - change - 14 Mar 2015
Title
# Config not outputing error messages when a required field is not fille...
[#33222] # Config not outputing error messages when a required field is not fille...
avatar compojoom
compojoom - comment - 14 Mar 2015

I've somehow managed to screw the pull request with another pull request.
Closing this and will open a new one.

avatar compojoom compojoom - change - 14 Mar 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-03-14 15:54:01
avatar compojoom compojoom - close - 14 Mar 2015

Add a Comment

Login with GitHub to post a comment