? ? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
1 Aug 2020

Pull Request for Issue # .

Summary of Changes

[3.10] backport #26293 into 3.10-dev thanks @ChristineWk

Testing Instructions

  • install 3.10-dev
  • install patchtester
  • go to the database and clear the field manifest_cache for the patchtester record in the extensions table.
  • set the nightly major update server
  • notice the pre update checker
  • notice that the pre update checker shows nothing as version for the patchtester and raises a notice
  • apply this patch
  • the updater now shows the string `Unknown version in this case and should not raise and notice any more.

Actual result BEFORE applying this Pull Request

Notice: Trying to get property 'version' of non-object in /home/xxx/xx/xxx/xxx/xxx/administrator/components/com_joomlaupdate/models/default.php on line 1410

Expected result AFTER applying this Pull Request

Unknown version

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 1 Aug 2020
avatar zero-24 zero-24 - change - 1 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Aug 2020
Category Administration com_joomlaupdate Language & Strings
avatar zero-24 zero-24 - change - 1 Aug 2020
Labels Added: ? ?
avatar ChristineWk
ChristineWk - comment - 1 Aug 2020

@zero24
1st point: should be installed 3.10 and not: install 4.0-dev (?)

Therefore, tried Patch in the current site: (previously updated of Issue #30235 (comment) to: 3.10-alpha1)

Confirm Actual Result

After applying Patch, got response:
Error
The patch could not be applied because it conflicts with a previously applied patch: administrator/components/com_joomlaupdate/models/default.php

avatar zero-24 zero-24 - change - 1 Aug 2020
The description was changed
avatar zero-24 zero-24 - edited - 1 Aug 2020
avatar zero-24
zero-24 - comment - 1 Aug 2020

@zero24
1st point: should be installed 3.10 and not: install 4.0-dev (?)

Thanks fixed.

Therefore, tried Patch in the current site: (previously updated of Issue #30235 (comment) to: 3.10-alpha1)

Confirm Actual Result

Thanks ?

After applying Patch, got response:
Error
The patch could not be applied because it conflicts with a previously applied patch: administrator/components/com_joomlaupdate/models/default.php

Seems you have more than on com_joomlaupdate patch installed?

avatar ChristineWk
ChristineWk - comment - 1 Aug 2020

Seems you have more than on com_joomlaupdate patch installed?
Not, that I know of :-) Will try again.

avatar ChristineWk
ChristineWk - comment - 1 Aug 2020

No, I haven't, but I think the reason is:
As you know, I had previous version: 3.9.21-dev+pr30157. It was a special PR with Patch-download.

After this, I updated successfully: #30235 (comment) to version:
3.10-dev-alpha1, but got the above Notice as shown under: "Actual Result".

That means, I think that I need a complete new 3.10 to be able to test this PR ...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30255.

avatar toivo toivo - test_item - 2 Aug 2020 - Tested successfully
avatar toivo
toivo - comment - 2 Aug 2020

I have tested this item successfully on 1024356

Tested successfully in 3.10.0-alpha2-dev using Wampserver 3.2.2 with PHP 7.4.8.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30255.

avatar ChristineWk ChristineWk - test_item - 2 Aug 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 2 Aug 2020

I have tested this item successfully on 1024356

Finally I got it.
Had problems with: go to the database and clear the field manifest_cache for the patchtester record in the extensions table.
Thanks for your assistance to @Harmageddon & @zero-24

Tried several times, because didn't get the "Actual Result" (Notice) on the other site (3.10.0-alpha2-dev).
Reason was: I had forgotten to set the Error Reporting .... (:-


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30255.

avatar Quy Quy - change - 2 Aug 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 2 Aug 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30255.

avatar zero-24 zero-24 - change - 9 Aug 2020
Labels Added: ?
avatar richard67 richard67 - alter_testresult - 9 Aug 2020 - toivo: Tested successfully
avatar richard67 richard67 - alter_testresult - 9 Aug 2020 - ChristineWk: Tested successfully
avatar richard67
richard67 - comment - 9 Aug 2020

Restored the previous test results on the issue tracker because they are still valid. Changes after the tests have been code style only.

avatar richard67 richard67 - close - 9 Aug 2020
avatar richard67 richard67 - merge - 9 Aug 2020
avatar richard67 richard67 - change - 9 Aug 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-09 21:26:07
Closed_By richard67
avatar richard67
richard67 - comment - 9 Aug 2020

Thanks!

Add a Comment

Login with GitHub to post a comment