? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
1 Aug 2020

Summary of Changes

As title says. This PR adds strings present in last version (3.7.0) of web links.
Installing the web links package will provide the new strings but these are not present in the other languages pack as they are absent from en-GB core distribution.
Using German in backend will show the strings have not been added/translated.

Testing Instructions

Install weblinks package. https://downloads.joomla.org/extensions/weblinks/3-7-0

Switch backend to German.
Set Debug Language on

Create a weblink.

Actual result BEFORE applying this Pull Request

Example:
Screen Shot 2020-08-01 at 11 32 31

Expected result AFTER applying this Pull Request

As the strings will now be present (after translation by German Team in next release), they will show Ok.
The French pack does already contain these missing strings

Screen Shot 2020-08-01 at 11 37 45

avatar infograf768 infograf768 - open - 1 Aug 2020
avatar infograf768 infograf768 - change - 1 Aug 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Aug 2020
Category Administration Language & Strings
avatar chmst chmst - test_item - 1 Aug 2020 - Tested successfully
avatar chmst
chmst - comment - 1 Aug 2020

I have tested this item successfully on e880cd0

By chance I am working on a site with the weblinks component right now - so could test at once.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30253.

avatar infograf768
infograf768 - comment - 2 Aug 2020

@chmst
We also miss 4 ini files. Grrr

plg_editors-xtd_weblink.ini
plg_editors-xtd_weblink
plg_system_weblinks.ini
plg_system_weblinks.sys.ini

Shall I add them here or in new patch? What you think?

avatar sanek4life
sanek4life - comment - 2 Aug 2020

@infograf768 I was creating 2 issues (418 & 419) that are currently in this component, but no one answered. is this component currently being developed here or in another directory?

avatar chmst
chmst - comment - 2 Aug 2020

Add it to this PR. It is an easy test

avatar infograf768
infograf768 - comment - 2 Aug 2020

@sanek4life
Any issue with weblinks is indeed to be created where you did it. Needs a volunteer to correct bugs there. Will have a look.

avatar infograf768 infograf768 - change - 2 Aug 2020
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 2 Aug 2020

@chmst
Done.

avatar chmst chmst - test_item - 2 Aug 2020 - Tested successfully
avatar chmst
chmst - comment - 2 Aug 2020

I have tested this item successfully on c5aa50a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30253.

avatar infograf768
infograf768 - comment - 2 Aug 2020

@HLeithner
Please merge.

avatar infograf768
infograf768 - comment - 2 Aug 2020

@sanek4life
Replied to both your issues (418 & 419) for weblinks.

avatar HLeithner HLeithner - close - 2 Aug 2020
avatar HLeithner HLeithner - merge - 2 Aug 2020
avatar HLeithner HLeithner - change - 2 Aug 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-02 19:05:38
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 2 Aug 2020

Thanks, I'm wondering why com_weblinks translations are still in core...

avatar infograf768
infograf768 - comment - 3 Aug 2020

Thanks, I'm wondering why com_weblinks translations are still in core...

It was decided to keep the web links ini files in core for the 3x series when web links were separated as we have no structure to propose specific languages for them.

avatar HLeithner
HLeithner - comment - 3 Aug 2020

thx for the info

avatar Bakual
Bakual - comment - 3 Aug 2020

More background to language files in weblinks: joomla-extensions/weblinks#383

avatar infograf768
infograf768 - comment - 3 Aug 2020

At this stage, all web links ini files are no more present in J4.

See joomla-extensions/weblinks#415 (comment)

Add a Comment

Login with GitHub to post a comment