Feeling Lucky
NPM Resource Changed
?
[#30250] - [4.0] Add padding to external link icon
- Fixed in Code Base
- 1 Aug 2020
- Medium
- Build: 4.0-dev
- # 30250
- Diff
- Quy:29335-icon-padding
User tests: Successful: Unsuccessful:
Pull Request for Issue #29335 .
Summary of Changes
Add padding to external link icon.
In Help Dashboard, padding is slightly wider due to markup, but at least it is better with this PR than before.
Testing Instructions
Run npm run build:css or download the installer package at the bottom of the page.
Navigate backend to see external links in:
- Post Installation Messages
- reCAPTCHA plugin
- Two Factor Authentication - Google Authenticator plugin
- Content Security Policy configuration and select Custom (see screenshots)
- Extensions > Install from Web
- Help Dashboard
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
chmst
- comment
- 1 Aug 2020
I have tested this item
Better than before, especially on the install-from-web.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30250.
HLeithner
- comment
- 1 Aug 2020
@Quy can you fix the cs please https://ci.joomla.org/joomla/joomla-cms/34360/1/24
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-01 22:57:12 |
| Closed_By | ⇒ | HLeithner |
HLeithner
- comment
- 1 Aug 2020
Thanks
Test results: OK = successfully
Post Installation Messages OK
reCAPTCHA plugin OK
Two Factor Authentication - Google Authenticator plugin OK
Content Security Policy configuration and select Custom (see screenshots) OK
Extensions > Install from Web OK
Help Dashboard OK / NOK !?
Before testing: already a little space
After testing: just a little more space
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30250.