User tests: Successful: Unsuccessful:
Adds JSON to .editorconfig to use 2 space indents instead of 1 tab.
Formats some JSON files.
Open any JSON file in the repository.
Notice that 2 space indentation is used.
No.
Status | New | ⇒ | Pending |
Category | ⇒ | Repository Front End Plugins |
I have tested this item
Found it out:
Edit a json file in the 4.0-dev branch on GitHub. Add some new code, e.g. new curly opening bracket, and after that some code, and then closing curly bracket, or anything for which you expect a clever editor who knows about the syntax of json to do the right indent automatically.
Result: Indent for 1 level is one tabulator.
Now edit some json file in the branch of this PR and check automatic indent in the same way.
Result: Indent for 1 level is two spaces.
Finally checked changes in the json files by code review. All fine.
Hmm, just thinking about it further: 1 tab is 1 byte, 2 spaces are 2 bytes ... don't we blow up the files with this change? ;-) (joking)
I have tested this item
Tested with PhpStorm 2020.2 and VSCode 1.48.0-insider
.stylelintrc.json
or plugins/editors/codemirror/fonts.json
.stylelintrc.json
or plugins/editors/codemirror/fonts.json
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-03 13:04:00 |
Closed_By | ⇒ | HLeithner | |
Labels |
Thanks
@SharkyKZ
You mean here on GitHub with their built-in editor? And edit a bit without saving, just to see if new lines are indended in the right way? Sorry if it's a silly question, but up to now I never cared about .editorconfig and what editor it is good for ;-)Update: Found it out, see test result below. All fine.