User tests: Successful: Unsuccessful:
Pull Request for Issue #29744 .
Backend Atum template changes
This PR sets css text-decoration:underline
for anchor elements by default.
This PR also sets text-decoration:none
to the following anchors:
reason why is explained / discussed in #29744
npm run build:css
Anchor in text is not underlined.
Anchor in text is underlined.
no changes required
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) NPM Change |
Could you please explain why you ignored comment #29744 (comment) ?
We have already a feature in Joomla to underline links if wanted.I'm just asking because I don't understand the concept of duplicate solutions and existing settings for nothing.
sorry overlooked... I totally agree with you to and perhaps we should create a new PR to remove the .a11y_highlight
after this issue is approved.
Is there something I should do to get these settings activated?
I think everyone will benefit with an underlined anchor in component output.
Is there something I should do to get these settings activated?
Looks like someone broke it
remove the .a11y_highlight after this
Please do not do that it is doing more than this pr
The reason that it is broken comes from #29251
com_users edit is opened for my user... but no Accessibility Settings tab to be seen.
the offending pr change it to com_admin not com_users and it did not include the accessibility tab
If you go to your account in com_users you will see it is still there
Category | Administration Templates (admin) NPM Change | ⇒ | Accessibility Administration NPM Change Templates (admin) |
I have found the setting and activated it. See screenshots below:
As the setting implies it will highlight anchors. (not all by the way... take a look at the white icons in the dark blue header top right.)
Besides the highlight I think all users would benefit a text-decoration underline on anchors in the component output. Not only the users who are aware of the availability of the a11y setting, able to find it and activate it. All users would benefit applying this PR.
Labels |
Added:
?
?
|
Labels |
Added:
NPM Resource Changed
?
Removed: ? |
I have tested this item
1. Applied Patch
2. ran npm run build:css
3. visited multiple sites
test unsuccessfully
test unsuccessfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30207.
@vdfk13 did you run 'npm run build:css' ? It is required to see the changes.
I have tested this item
Followed the instructions above and visited the given pages
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-04 12:24:43 |
Closed_By | ⇒ | roland-d | |
Labels |
Added:
?
?
Removed: ? |
Could you please explain why you ignored comment #29744 (comment) ?
We have already a feature in Joomla to underline links if wanted.
I'm just asking because I don't understand the concept of duplicate solutions and existing settings for nothing.