NPM Resource Changed ? ? ? Pending

User tests: Successful: Unsuccessful:

avatar hans2103
hans2103
28 Jul 2020

Pull Request for Issue #29744 .

Summary of Changes

Backend Atum template changes
This PR sets css text-decoration:underline for anchor elements by default.
This PR also sets text-decoration:none to the following anchors:

  • anchor in header
  • anchor in sidebar-wrapper
  • anchor in sidebar-nav
  • anchor in quick-icons

reason why is explained / discussed in #29744

Testing Instructions

  • apply patch
  • run cli command npm run build:css
  • refresh page Joomla Administrator > System > Post Install Messages

Actual result BEFORE applying this Pull Request

Anchor in text is not underlined.

Schermafdruk 2020-07-28 09 03 00

Extra screenshots from other pages BEFORE applying this Pull Request

Schermafdruk 2020-07-28 09 02 40

Schermafdruk 2020-07-28 09 02 45

Expected result AFTER applying this Pull Request

Anchor in text is underlined.

Schermafdruk 2020-07-28 09 01 17

Extra screenshots from other pages AFTER applying this Pull Request

Schermafdruk 2020-07-28 09 01 33

Schermafdruk 2020-07-28 09 01 22

Documentation Changes Required

no changes required

avatar hans2103 hans2103 - open - 28 Jul 2020
avatar hans2103 hans2103 - change - 28 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2020
Category Administration Templates (admin) NPM Change
avatar ReLater
ReLater - comment - 28 Jul 2020

Could you please explain why you ignored comment #29744 (comment) ?
We have already a feature in Joomla to underline links if wanted.

I'm just asking because I don't understand the concept of duplicate solutions and existing settings for nothing.

avatar hans2103
hans2103 - comment - 28 Jul 2020

Could you please explain why you ignored comment #29744 (comment) ?
We have already a feature in Joomla to underline links if wanted.

I'm just asking because I don't understand the concept of duplicate solutions and existing settings for nothing.

sorry overlooked... I totally agree with you to and perhaps we should create a new PR to remove the .a11y_highlight after this issue is approved.

Is there something I should do to get these settings activated?

  • Joomla Administrator > User Menu > Accessibility Settings
  • com_users edit is opened for my user... but no Accessibility Settings tab to be seen.

I think everyone will benefit with an underlined anchor in component output.

avatar brianteeman
brianteeman - comment - 28 Jul 2020

Is there something I should do to get these settings activated?

Looks like someone broke it

remove the .a11y_highlight after this

Please do not do that it is doing more than this pr

avatar brianteeman
brianteeman - comment - 28 Jul 2020

The reason that it is broken comes from #29251

com_users edit is opened for my user... but no Accessibility Settings tab to be seen.
the offending pr change it to com_admin not com_users and it did not include the accessibility tab

If you go to your account in com_users you will see it is still there

avatar Quy
Quy - comment - 29 Jul 2020

Is there something I should do to get these settings activated?

See PR #29226

avatar chmst chmst - change - 29 Jul 2020
Category Administration Templates (admin) NPM Change Accessibility Administration NPM Change Templates (admin)
avatar hans2103
hans2103 - comment - 29 Jul 2020

I have found the setting and activated it. See screenshots below:

Schermafdruk 2020-07-29 09 15 39

Schermafdruk 2020-07-29 09 16 11

Schermafdruk 2020-07-29 09 17 28

As the setting implies it will highlight anchors. (not all by the way... take a look at the white icons in the dark blue header top right.)
Besides the highlight I think all users would benefit a text-decoration underline on anchors in the component output. Not only the users who are aware of the availability of the a11y setting, able to find it and activate it. All users would benefit applying this PR.

avatar hans2103 hans2103 - change - 1 Aug 2020
Labels Added: ? ?
avatar hans2103 hans2103 - change - 2 Aug 2020
Labels Added: NPM Resource Changed ?
Removed: ?
avatar johndeutesfeld johndeutesfeld - test_item - 3 Aug 2020 - Tested successfully
avatar johndeutesfeld
johndeutesfeld - comment - 3 Aug 2020

I have tested this item successfully on a70796a

1. Applied Patch
2. ran npm run build:css
3. visited multiple sites


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30207.

avatar vdfk13
vdfk13 - comment - 3 Aug 2020

test unsuccessfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30207.

avatar hans2103
hans2103 - comment - 4 Aug 2020

test unsuccessfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30207.

@vdfk13 did you run 'npm run build:css' ? It is required to see the changes.

avatar johndeutesfeld
johndeutesfeld - comment - 4 Aug 2020

image

This is what my result looks like after following the testing instructions.

avatar nurcihandem nurcihandem - test_item - 4 Aug 2020 - Tested successfully
avatar nurcihandem
nurcihandem - comment - 4 Aug 2020

I have tested this item successfully on a70796a

Followed the instructions above and visited the given pages


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30207.

avatar roland-d roland-d - change - 4 Aug 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-08-04 12:24:43
Closed_By roland-d
Labels Added: ? ?
Removed: ?
avatar roland-d roland-d - close - 4 Aug 2020
avatar roland-d roland-d - merge - 4 Aug 2020

Add a Comment

Login with GitHub to post a comment