Feeling Lucky
?
[#30204] - Missing FA for icon-save
- Fixed in Code Base
- 28 Jul 2020
- Medium
- Build: 4.0-dev
- # 30204
- Diff
- N6REJ:30191
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #30191
Summary of Changes
change icon class for "icon-save" to "fas fa-save"
Testing Instructions
go to administrator/index.php?option=com_users&view=group&layout=edit&id=9
via inspector verify both save button icons are using "fas fa-save" instead of "icon-save"
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
sandewt
- comment
- 28 Jul 2020
I have tested this item
I noticed that there are two spaces between "button-save btn btn-success".
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30204.
sandewt
- comment
- 28 Jul 2020
I noticed that there are two spaces between "button-save btn btn-success".
N6REJ
- comment
- 28 Jul 2020
I noticed that there are two spaces between "button-save btn btn-success".
There's another pr pending dealing with that whole button class issue.. I'll resolve it there.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-28 14:30:54 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
infograf768
- comment
- 28 Jul 2020
tks
I have tested this item✅ successfully on 225e913
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30204.