[#30199] - Update en-GB.ini
- Closed
- 26 Mar 2021
- Medium
- Build: staging
- # 30199
- Diff
- diddipoeler:staging
- Success Hound Smells good to me. Woof! Details
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr Build is passing Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
JGLOBAL_BOTTOM
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
Es sind diese Variablen vorhanden:
JGLOBAL_TOP="Top"
JGLOBAL_LEFT="Left"
JGLOBAL_RIGHT="Right"
Diese fehlt:
JGLOBAL_BOTTOM
Please write English :) Where did you get the non-translated language key?
I'd rather deprecate "JGLOBAL_TOP" (and remove in 4.0) as that one doesn't seem to be used in the project.
I'm not sure if it makes much sense to add another unused language string.
Also, the strings should be alphaordered. So it should be between those two:
JGLOBAL_BLOG_LAYOUT_OPTIONS="Blog Layout"
JGLOBAL_CATEGORIES_OPTIONS="Categories"
Testing Instructions?
We shouldn't be adding strings that are not used
@diddipoeler sorry, but there is no reason for introducing an unused language key. Please give us information which problem is be solved with your PR.
Closing for reasons stated above,
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-03-26 13:48:44 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
Information Required
?
|
||
Please give some additinal information and testing instructions. Were is this Language key in use?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30199.