Feeling Lucky
?
[#30191] - [4.0] Icon- TO fa incomplete
- Closed
- 27 Jul 2020
- Medium
- Build: staging
- # 30191
Steps to reproduce the issue
According to the information in the descritpion of Icon- TO fa ( part 3 ) #28075 the icon for the Save-Group button should have been changed from icon-save to fas fa-save
There may be others I have not checked
Actual result
joomla-cms-bot
- | Labels |
Added:
?
|
||
infograf768
- comment
- 26 Jul 2020
Is'nt it simply
diff --git a/layouts/joomla/toolbar/iconclass.php b/layouts/joomla/toolbar/iconclass.php
index 6ed910c..a42fa6a 100644
--- a/layouts/joomla/toolbar/iconclass.php
+++ b/layouts/joomla/toolbar/iconclass.php
@@ -36,4 +36,8 @@
$icon = 'fas fa-save';
}
+elseif ($icon === 'save')
+{
+ $icon = 'fas fa-save';
+}
elseif ($icon === 'mail')
{
infograf768
- comment
- 26 Jul 2020
maybe also to add in /layouts/joomla/button/iconclass.php
N6REJ
- comment
- 27 Jul 2020
i'll double check it but I think your right it SHOULD be button/iconclass.php @infograf768.. have it done in next 24hrs.. no sleep yet
infograf768
- comment
- 27 Jul 2020
in both files. tested already ok the one in the diff above
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-27 19:14:02 |
| Closed_By | ⇒ | N6REJ |
Ping @N6REJ .