[#30181] - [4.0] com_joomlaupdate reference to class HtmlView
- Fixed in Code Base
- 8 Aug 2020
- Medium
- Build: 4.0-dev
- # 30181
- Diff
- hans2103:feature/joomlaupdate-reference-to-class-htmlview
- Success Hound Smells good to me. Woof! Details
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr Build is passing Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
stumbled upon this issue while working on #30171 and #30168
Summary of Changes
On of the benefits of working with an IDE like PHPStorm is that it gives me more information about my code then vi edito can do. :-) For instance.. CMD + Click on a reference to head directly to that function in that file.
If set correctly!
Testing Instructions
-
Open an IDE like PHPStorm and open the changed files. (for instance : default_nodownload.php)
-
Try to cmd/ctrl + click on
$this->getModel() -
all template files from joomlaupdate should reference to the same class HtmlView (if needed)
Only default_reinstall is set correct.
Actual result BEFORE applying this Pull Request
PHPStorm shows a yellow background color to indicate something. When hover HTML it informs you that class HTML cannot be found.
Expected result AFTER applying this Pull Request
All files reference to the same class HtmlView, if needed... default_updatemefirst.php does not need the reference.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
I have tested this item
Tested successfully with PHP Storm
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30181.
roland-d
- | Labels |
Added:
Conflicting Files
?
|
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30181.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-08 12:42:12 |
| Closed_By | ⇒ | roland-d | |
| Labels |
Added:
?
Removed: Conflicting Files |
||
I have tested this item✅ successfully
After applying the PR, the IDE (I was using PHP Storm) indicates no more errors