?

User tests: Successful: Unsuccessful:

avatar mbabker mbabker - open - 31 Jan 2014
avatar wilsonge
wilsonge - comment - 1 Feb 2014

You should probably edit the comments in the file itself about being responsible for <5.4 only so people don't try and remove it in the future

avatar mbabker
mbabker - comment - 1 Feb 2014

It's not just <5.4 only per the tracker report. Some 5.5 distros are missing certain JSON based stuff.

avatar wilsonge
wilsonge - comment - 1 Feb 2014

Yeah I know. I mean you should probably edit https://github.com/joomla/joomla-cms/blob/staging/libraries/compat/jsonserializable.php#L12 to reflect that

avatar mbabker
mbabker - comment - 1 Feb 2014

Ahh, gotcha

avatar wilsonge
wilsonge - comment - 11 Apr 2014

I think we should be trying to merge this for 3.3 before it becomes a major issue.

avatar betweenbrain
betweenbrain - comment - 11 Apr 2014

:+1:

avatar mbabker mbabker - change - 29 May 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-05-29 18:58:56
avatar mbabker mbabker - close - 29 May 2014
avatar mbabker mbabker - close - 29 May 2014
avatar Bakual
Bakual - comment - 29 May 2014

Merged, thanks!

avatar mbabker mbabker - head_ref_deleted - 22 May 2015

Add a Comment

Login with GitHub to post a comment