Feeling Lucky
?
?
[#30173] - [3.9] Fix missing typecasting SQL query plugin privacy actionlogs
- Fixed in Code Base
- 17 Aug 2020
- Medium
- Build: staging
- # 30173
- Diff
- sandewt:patch-1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #30164 .
Summary of Changes
This PR filters the input variable of the SQL query.
Testing Instructions
???
Actual result BEFORE applying this Pull Request
See line 45:
->where($this->db->quoteName('a.user_id') . ' = ' . $user->id);
Expected result AFTER applying this Pull Request
->where($this->db->quoteName('a.user_id') . ' = ' . (int) $user->id);
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
alikon
- comment
- 23 Jul 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30173.
Quy
- comment
- 23 Jul 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30173.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 23 Jul 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30173.
sandewt
- comment
- 24 Jul 2020
@alikon and @Quy, thanks for testing :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30173.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-17 11:00:24 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
HLeithner
- comment
- 17 Aug 2020
Thanks
@sandewt For the testing instructions you could write "Code review" and link to https://docs.joomla.org/Secure_coding_guidelines like you've done in the issue. For a real test (which always is better) it would need to find out what the changed code does and provide instructions. In this case here it would be to create a privacy export request and then process this request.