[#30148] - [4.0][com_installer] Move icon to the right of text in button
- Closed
- 4 Sep 2020
- Medium
- Build: 4.0-dev
- # 30148
- Diff
- Quy:30018-double-icons
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #30018.
Summary of Changes
Override link to hide the external icon.
Testing Instructions
Apply PR
Run npm run build:css
Go to System > Extensions
Go to the Install from Web tab
Click any extension
Actual result BEFORE applying this Pull Request
Actual result AFTER
applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
.item-view {
.card-body {
a[target="_blank"]::before {
display: none;
}
}
looks like is missing a }, i.e should be
.item-view {
.card-body {
a[target="_blank"]::before {
display: none;
}
}
}
Doesnt this remove the functionality of notifying the user that the link opens in a new window?
my2cent:
The external link information was useful, but the other icons are not, they give no information here, as the text on the buttons is sufficient.
What do you think about removing the other icons?
Or move the link icon to the right of the text?
| Labels |
Added:
NPM Resource Changed
?
|
||
| Title |
|
||||||
LTR
RTL
Note: other issues with RTL on this screen:
dd should have margin-right: 0;instead of margin-left: 0;
Some values, like the Compatible Versions should be LTR while still aligned right
therefore we should have in RTL
.col-md-8 dd {
margin-bottom: .5rem;
margin-right: 0;
direction: ltr;
text-align: right;
}
to get
May I suggest to use only one icon?
my2cent:
The external link information was useful, but the other icons are not, they give no information here, as the text on the buttons is sufficient.
What do you think about removing the other icons?
dito
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-04 14:24:12 |
| Closed_By | ⇒ | Quy |
Can you add a screenshot for AFTER patch please.