[#30144] - Fix possible warning in the System-Debug's DataFormatter.php file
- Fixed in Code Base
- 1 Dec 2020
- Medium
- Build: 4.0-dev
- # 30144
- Diff
- dryabov:patch-2
- Success Hound Smells good to me. Woof! Details
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/drone/pr Build is passing Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Fix a warning htmlspecialchars() expects parameter 1 to be string, array given in the case of array passed as an argument in the stack trace.
Summary of Changes
Add a check for special case of is_array($arg).
Testing Instructions
Declare a function like
function TestMe($array) {
JText::_($array[0]);
}
and call it TestMe(['qweasd']) with enabled language logging.
Actual result BEFORE applying this Pull Request
<b>Warning</b>: htmlspecialchars() expects parameter 1 to be string, array given in <b>.../plugins/system/debug/src/DataFormatter.php</b> on line <b>66</b>
Expected result AFTER applying this Pull Request
No warning message
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
Some questions on Testing-Instruction:
- What does mean "enabled language logging"
- Output BEFORE is to find here 'administrator/logs/...' or as font-end message?
Thanks
I am afraid this one has beaten me. I put the following in cassiopeia:
function TestMe($array) {
echo Text::_($array[0]);
}
TestMe(['qweasd']);
But following through the code with the debugger the section where the change is made is never executed. In the debug bar I see the stack trace for qweasd whether or not the patch is applied. What am I doing wrong?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30144.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30144.
set RTC
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-01 09:30:37 |
| Closed_By | ⇒ | HLeithner |
Thanks
I have tested this item✅ successfully on ee90cf1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30144.