[#30134] - [4.0][api][com_content] render metafields "metakey", "metadesc" and "metadata" and fields "featured" and "access"
- Fixed in Code Base
- 25 Jul 2020
- Medium
- Build: 4.0-dev
- # 30134
- Diff
- alikon:patch-124
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #30130, #30135
Summary of Changes
render metafields: metakey, metadesc, metadata, featured, access
Testing Instructions
edit an article
add content to metakey, metadesc, metadata fields
save
call the api
--for article list
{{base_url}}api/index.php/v1/content/article
--for article item
{{base_url}}api/index.php/v1/content/article/{id}
Actual result BEFORE applying this Pull Request
no render of metakey, metadesc, metadata, featured, access, fields
Expected result AFTER applying this Pull Request
Documentation Changes Required
probably ?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
@chetanmadaan It seems you have just added your test result here on GitHub. It would have been better if you had done it on the issue tracker here https://issues.joomla.org/tracker/joomla-cms/30134 using the "Test this" button, then the test would be counted correctly. This time I have done this for you by setting your test result in the issue tracker, so here all is ok now. But it would be great if you test a PR next time use the issue tracker for setting the test result. Thanks in advance, and thanks for testing here.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.
| Labels |
Added:
?
?
|
||
I see the test this button. My bad.
@chetanmadaan All fine. Now as it has 2 good tests, the PR is RTC, means "ready to commit", so it will be merged sooner or later. Thanks for reporting the issue and testing the PR.
Well, Thank you for being the mentor on the testing bit!
| Labels | |||
| Status | Ready to Commit | ⇒ | Pending |
Back to pending due to recent changes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.
With blog sample data:
-
Articles list
-
Single article
@particthistle @chetanmadaan Could you test again after last changes? Thanks in advance.
| Title |
|
||||||
@particthistle @chetanmadaan P.S.: Note that testing instructions have been changed due to more fields being added with this PR now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.
I have tested this item
Works! Featured and access column show up fine now.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.
Thank you @richard67 @alikon
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-25 23:00:19 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on 060df8d
Tested successfully.
BEFORE Applying patch:
No metafield data displayed.
AFTER Applying patch:
Metafield data displayed in the data.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30134.