[#3013] - Don't include sample images in update packages
- Closed
- 3 Feb 2014
- Medium
- Build: staging
- # 3013
- Diff
- mbabker:noImagesOnUpdate
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This modifies the 3.x build script to exclude the sample images we distribute from the update packages. They serve no real purpose once a site is established and site owners who wish to remove this content should be free to do so. Note that the full install package is unaffected and these images will continue to be bundled there.
I've done this as a PR to solicit feedback in case there are individuals who may think these are important to retain in the update packages.
+1. Also I'm curious what happens if I've deleted a core-image and uploaded my own under the same name, and then run the updater. Does my image get overwritten?
Presumably, yes, your image would get overwritten.
On Thu, Jan 30, 2014 at 6:55 PM, Chad Windnagle notifications@github.comwrote:
+1. Also I'm curious what happens if I've deleted a core-image and
uploaded my own under the same name, and then run the updater. Does my
image get overwritten?Reply to this email directly or view it on GitHub#3013 (comment)
.
Then that's definitely a reason to chuck 'em. Could result in overwriting my content which should never happen.
Please remove. Helps keep things uncluttered a bit more.
Great change! 
Get rid of them. It's already bad enough they're there when you never want to install the sample data to begin with. ;-)
I'll merge this in when I have a few minutes to do the same for 2.5 and the nightly build scripts.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-02-03 19:05:29 |
Yes please - its very frustrating to remove them only for them to come back again.