?
avatar SharkyKZ
SharkyKZ
17 Jul 2020

Pull Request for Issue # .

Summary of Changes

Use null coalescing operator over ternary operator and instanceof checks in methods with nullable class typehints.

Testing Instructions

  1. Code review.
  2. Browse around in frontend and backend.

Expected result AFTER applying this Pull Request

  1. Joomla still works.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 17 Jul 2020
avatar richard67
richard67 - comment - 17 Jul 2020

Fore some reason this PR doesn't appear in the issue tracker? @zero-24 Any idea? Or who could know?

avatar SharkyKZ SharkyKZ - change - 19 Jul 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-07-19 09:52:55
Closed_By SharkyKZ
Labels Added: ?
avatar SharkyKZ SharkyKZ - close - 19 Jul 2020
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jul 2020
Category Front End com_content Libraries
avatar zero-24
zero-24 - comment - 21 Jul 2020

Fore some reason this PR doesn't appear in the issue tracker? @zero-24 Any idea? Or who could know?

Please open for such issues an issue here: joomla/jissues. I have no access to the issue tracker to check the reason behind it nor do i want to have any access there ;) The last time it was an issue with webhooks that run on error and it seemed to be an upstream issue from GitHub but best is to open an issue there so this can be checked.

Add a Comment

Login with GitHub to post a comment