? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
14 Jul 2020

Summary of Changes

This backports the _supportNullValue from the base table class to Joomla 3.10

It bases on this commits against 4.x:
447983b
f472a7c
ba6641c

This is fully B/C and there are not intentions to change to NULL Dates in 3.x. This here just has the intention to allow extension devs to use the same code for the tables in 3.10 and 4.x including the _supportNullValue switch.

Testing Instructions

  • Apply the patch and navigate arround
  • create an article
  • checkout an article
  • checkin an article

Actual result BEFORE applying this Pull Request

It works

Expected result AFTER applying this Pull Request

It still works but now has the optional supportNullValue switch for developers backported.

Documentation Changes Required

Maybe it is worth mention that in the doc for the 4.x changes.

cc @wilsonge

avatar zero-24 zero-24 - open - 14 Jul 2020
avatar zero-24 zero-24 - change - 14 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jul 2020
Category Libraries
avatar zero-24 zero-24 - change - 14 Jul 2020
Title
Backport Table _supportNullValue handling to 3.10
[3.10] Backport Table _supportNullValue handling to 3.10
avatar zero-24 zero-24 - edited - 14 Jul 2020
avatar zero-24 zero-24 - change - 14 Jul 2020
Labels Added: ?
avatar Quy
Quy - comment - 19 Jul 2020

Is this PR for #29441 and #29429?

avatar zero-24
zero-24 - comment - 20 Jul 2020

Only the first issue i guess this does not change anything for existing extensions nor provide any kind of migration for them it just allow them to use the same code for the table class in 3.10 and 4.0

avatar Quy Quy - test_item - 31 Jul 2020 - Tested successfully
avatar Quy
Quy - comment - 31 Jul 2020

I have tested this item successfully on f00381a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30102.

avatar adj9
adj9 - comment - 29 Aug 2020

One thing is not clear to me: how do I check the article?

avatar zero-24
zero-24 - comment - 29 Aug 2020

What do you mean by check the article?

avatar adj9
adj9 - comment - 29 Aug 2020

The third point of Testing Instructions, "checkout an article".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30102.

avatar zero-24
zero-24 - comment - 29 Aug 2020

You checkout an article when you edit an article in the backend. When you save & close the article they are checked in again.

avatar chmst chmst - test_item - 25 Sep 2020 - Tested successfully
avatar chmst
chmst - comment - 25 Sep 2020

I have tested this item successfully on d8c088b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30102.

avatar HLeithner HLeithner - change - 25 Sep 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-25 08:26:54
Closed_By HLeithner
avatar HLeithner HLeithner - close - 25 Sep 2020
avatar HLeithner HLeithner - merge - 25 Sep 2020
avatar HLeithner
HLeithner - comment - 25 Sep 2020

Thanks

avatar zero-24
zero-24 - comment - 29 Sep 2020

Add a Comment

Login with GitHub to post a comment