? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
13 Jul 2020
  • fix typehint syntax in single line comment to meet code standards
  • fix multi line comment syntax
  • reindent docblock
avatar PhilETaylor PhilETaylor - open - 13 Jul 2020
avatar PhilETaylor PhilETaylor - change - 13 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jul 2020
Category Front End Plugins
avatar PhilETaylor PhilETaylor - change - 13 Jul 2020
Labels Added: ?
avatar PhilETaylor PhilETaylor - change - 13 Jul 2020
Title
[4.0] fix typehint syntax
[4.0] fix typehint syntax & other comment issues
avatar PhilETaylor PhilETaylor - edited - 13 Jul 2020
avatar PhilETaylor PhilETaylor - change - 13 Jul 2020
The description was changed
avatar PhilETaylor PhilETaylor - edited - 13 Jul 2020
avatar ceford
ceford - comment - 14 Jul 2020

Where to look for changes?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30091.

avatar PhilETaylor
PhilETaylor - comment - 14 Jul 2020

The only changes are comments - so just code review, nothing to test

avatar ChristineWk ChristineWk - test_item - 14 Jul 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 14 Jul 2020

I have tested this item successfully on 1d84059


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30091.

avatar richard67 richard67 - test_item - 14 Jul 2020 - Tested successfully
avatar richard67
richard67 - comment - 14 Jul 2020

I have tested this item successfully on 1d84059


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30091.

avatar richard67 richard67 - change - 14 Jul 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 14 Jul 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30091.

avatar richard67 richard67 - change - 14 Jul 2020
Labels Added: ?
avatar laoneo laoneo - change - 23 Jul 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-07-23 08:52:56
Closed_By laoneo
avatar laoneo laoneo - close - 23 Jul 2020
avatar laoneo laoneo - merge - 23 Jul 2020
avatar laoneo
laoneo - comment - 23 Jul 2020

Thanks!

Add a Comment

Login with GitHub to post a comment