[#30089] - [4.0] Change all
- Fixed in Code Base
- 13 Jul 2020
- Medium
- Build: 4.0-dev
- # 30089
- Diff
- PhilETaylor:shorttags
User tests: Successful: Unsuccessful:
Summary of Changes
Change all <?= to <?php echo in line with the Joomla Code Standards
Testing Instructions
Just look at the code.
Actual result BEFORE applying this Pull Request
Everything works but some views use <?=
Expected result AFTER applying this Pull Request
Everything works and all code uses <?php echo
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer com_modules Modules Front End com_users |
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30089.
The 6 files in this PR are all headed as copyright OSM under GPL - I dont see any of Niks copyright at the top of these files.
I deliberately excluded vendors from my fixes and I'm fully away of the stupidity of the Joomla Code Standard refusing php short tags <? and <?= tags when its included vendor code (including symfony code) contains them.
Well that's an argument for those above my pay grade and unrelated to this PR.
The current published Joomla Code Standards state to not use shorthand tags, therefore all I have done is bring code in line with those, regardless of the stupidity of the Joomla Code Standards which are ancient and do not take modern PHP into account (PHP 7+ stuff)
Always use the full
<?php ... ?>to delimit PHP code, not the<? ... ?>shorthand
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30089.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30089.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30089.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-13 15:19:54 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
?
|
||
Good luck changing Niks code