[#30087] - [4.0] Menu items modal: adding missing filters
- Fixed in Code Base
- 14 Jul 2020
- Medium
- Build: 4.0-dev
- # 30087
- Diff
- infograf768:4.0_menu_modal_filters
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Menus modals do not display filtering by Menu Type in backend and also in frontend.
Also, in frontend, no filtering by Parent Menu item
This PR corrects this so that filtering in modals is similar to filtering in menu tems Manager
Testing Instructions
Edit an article in backend and also in frontend.
Through CMS Content display a Menu Modal
Actual result BEFORE applying this Pull Request
Backend
Frontend
Expected result AFTER applying this Pull Request
Backend
Frontend
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Front End |
The menu dropdown is at the top and not listed with the other dropdowns.
I have tested this item
The front end looks strange with the Menu Select drop-down being full page width.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30087.
The front end looks strange with the Menu Select drop-down being full page width.
Yep. Only way would be to create a specific css. Not sure what precisely as using flex is not my specialty. This would be for another pr.
The menu dropdown is at the top and not listed with the other dropdowns.
This is fine. It's designed this way in backend. com_menu has a specific searchtools layout.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30087.
| Labels |
Added:
?
?
|
||
Please merge as I have a PR for the css solving both the menutype custom-select display and the bcakground of the custom-select arrow
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-14 10:16:13 |
| Closed_By | ⇒ | richard67 | |
| Labels | |||
Thanks!
I have tested this item✅ successfully on d52f9ec
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30087.