?
avatar MartijnMaandag
MartijnMaandag
12 Jul 2020

In the help Screens there are internal links to other Help Screens. When I hit a link in Dutch I arrive at an English language item instead of the Dutch one.

Steps to reproduce the issue

When you hit the help button you will arrive at the right language. Example:
https://help.joomla.org/proxy?keyref=Help40:Components_Banners_Banners&lang=en
When you do the same from another Help Screen (like the Options Help Screen) there is another link (no language):
https://help.joomla.org/proxy?keyref=Help4.x:Components_Banners_Banners
I am not technical and don't know where to solve this. In the docs helpscreens we use S:MyLanguage/ to point to the right language.
If you want a language pack to test this. Dutch is available: https://www.joomlacommunity.nl/downloads/joomla-4/90-nederlands-taalpakket-nl-nl-joomla-4-0-0-beta

System information (as much as possible)

Joomla 4 beta2

Additional comments

avatar MartijnMaandag MartijnMaandag - open - 12 Jul 2020
avatar joomla-cms-bot joomla-cms-bot - labeled - 12 Jul 2020
avatar brianteeman
brianteeman - comment - 12 Jul 2020

I'm a little confused about where you are clicking. Please could you add screenshots

avatar MartijnMaandag
MartijnMaandag - comment - 12 Jul 2020

After selecting help (first screen) there will be ascreen shot 2020-07-12 at 09 22 38 pop-up.screen shot 2020-07-12 at 09 22 41


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30080.

avatar infograf768
infograf768 - comment - 12 Jul 2020

Same in J3 afaik

avatar brianteeman
brianteeman - comment - 12 Jul 2020

Just checking I understand that the problem is with the second screenshot and the link on that page.

I can see that the link on that page is correct on the source docs page with the special tag

From what I can tell the problem is with the way help.joomla.org and docs.joomla.org are linked together.

It's not a core joomla issue as that code is not part of this repo. - not sure where it does live - sorry

This "problem" is the same in j3

avatar mbabker
mbabker - comment - 12 Jul 2020

The help proxy just renders the contents of a docs page as parsed from the MediaWiki API with rewrites of the URLs to stay within the proxy. Aside from other minor revisions to unlink images or remove red links (meaning a wiki page does not exist for that link), it does not do anything special with page contents beyond printing them.

avatar mbabker
mbabker - comment - 12 Jul 2020

In the docs helpscreens we use S:MyLanguage/ to point to the right language.

This generally is not the intended behavior for the help proxy. Generally, the language of the CMS interface is the preferred language, then if a page is not found in that language it falls back to English (the same way the CMS translations work). Using that special URL would not work correctly anyway because the help screen proxy is making a server-to-server API call to the MediaWiki API meaning no client information about the user who requested the page is provided through the API context for those calls to do anything meaningful with it (such as cookies or user agent strings).

I would suggest this item be closed as working as intended. The help proxy is not MediaWiki and if you want MediaWiki’s functionality then I would just rip out the middleman and have the help buttons open directly to the docs wiki and remove all inline rendering of help from the CMS.

avatar mbabker
mbabker - comment - 12 Jul 2020

It's not a core joomla issue as that code is not part of this repo. - not sure where it does live - sorry

https://github.com/joomla/help.joomla.org

Unlike other teams I believe in transparency and open sourcing of project resources to the extent practical.

avatar richard67 richard67 - change - 12 Jul 2020
Status New Expected Behaviour
Closed_Date 0000-00-00 00:00:00 2020-07-12 16:06:38
Closed_By richard67
avatar richard67 richard67 - close - 12 Jul 2020
avatar richard67
richard67 - comment - 12 Jul 2020

Closing as expected behavior for the reason stated above: #30080 (comment)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30080.

avatar richard67
richard67 - comment - 12 Jul 2020

Thanks @mbabker for the detailed information.

avatar brianteeman
brianteeman - comment - 12 Jul 2020

I dont agree that it is the expected behaviour from a user perspective at all. However I do agree that this is not the repo where it can be addressed

avatar richard67
richard67 - comment - 12 Jul 2020

I dont agree that it is the expected behaviour from a user perspective at all. However I do agree that this is not the repo where it can be addressed

@brianteeman Fully agree. Expected behavior was regarding the CMS, not regarding the help Wiki or the help proxy.

avatar mbabker
mbabker - comment - 12 Jul 2020

I dont agree that it is the expected behaviour from a user perspective at all.

S:MyLanguage can’t be used from an API context, I rechecked this before walking away from the computer. This is why that is rewritten out of the URLs in the proxy and where possible the language code provided in the query string when requesting a proxy page is used. The one thing it isn’t doing, and I personally think this benefits nobody to do, is arbitrarily rewrite every rendered link to use the language code from the proxy request query string, that to me creates more end user confusion (why is an English rendered page generating links to German pages?). Also, there is heavy caching on the proxy to avoid bombarding the MediaWiki API, so a French user seeing an English page may have different expected links than a Dutch user. Not things that are easily dealt with short of disabling the cache integration, too many user dynamics to get it “right”.

About the only sane thing I can think of is to un-hide the “Other languages” node (it’s hidden with CSS only and not stripped from the DOM like other edits do). But any automatic language resolution in the same way that MediaWiki behaves just isn’t going to work when you’re dealing with the API and server-to-server communications. That’s why I said if you want what the help buttons render to behave exactly as the docs wiki does, the best option is to link directly to the docs wiki and eliminate all the pieces that try to render the help inline into the CMS. Sure would make my life easier at least.

avatar ceford
ceford - comment - 12 Jul 2020

I see this problem is inherited from Joomla 3. It seems to me that links that we have entered as [[S:MyLanguage/Help4.x:Components_Banners_Tracks|Banner Tracks Manager]] should be [[Help40:Components_Banners_Tracks/en|Banner Tracks Manager]]. Now testing to see if it works to produce the desired behaviour.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30080.

avatar ceford
ceford - comment - 12 Jul 2020

Arghh! The translate tags disappeared from that last comment and I don't know how to fix it.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30080.

avatar richard67
richard67 - comment - 12 Jul 2020

@ceford Use the "insert code" button or quote that part of your comment with "`" so GitHub shows it as it is.

avatar ceford
ceford - comment - 12 Jul 2020

What I meant to say is that the internal Help links should be one or other of the following:

*Test 1: [[Help40:Components_Banners_Tracks/<translate>
en</translate>|<translate>
Banner Tracks Manager</translate>]]

*Test 2: [https://help.joomla.org/proxy?keyref=Help40:Components_Banners_Tracks&lang=<translate>
en</translate> <translate>
Banner Tracks Manager</translate>]

This way the required language code is in the translation. Currently testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30080.

avatar mbabker
mbabker - comment - 12 Jul 2020

The first one. The second one forcibly links the pages from the docs subdomain to the help subdomain.

avatar MartijnMaandag
MartijnMaandag - comment - 14 Jul 2020

@ceford and me tested and found a way in docs to have links act like we want in the helpscreens.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30080.

Add a Comment

Login with GitHub to post a comment