[#30075] - [4.0] Fixed filtering by multiple tags in a blog layout
- Fixed in Code Base
- 12 Jul 2020
- Medium
- Build: 4.0-dev
- # 30075
- Diff
- Lippy13:patch-1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Filtering by multiple tags in a category blog layout works again.
Testing Instructions
- Create a couple of tags. Let's call them 'foo' and 'bar'.
- Create a couple of articles. Assign one the 'foo' tag, and the other the 'bar' tag.
- Create a new menu item of type Category Blog. Leave it uncategorised, and add both 'foo' and 'bar' tags to filter it by. Save.
- Browse to the newly created menu item in the frontend.
Actual result BEFORE applying this Pull Request
Error 500 and no articles appear.
Expected result AFTER applying this Pull Request
Tags are correctly filtered and both articles appear.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
That change doesn't makes sense to me because it's basically the same. If this is really broken we should check why whereIn fails here.
I have tested this item
Tested with MySQLi, MySQL (PDO) and PostgreSQL (PDO).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30075.
@HLeithner I've missed it too at the first time: It is a subquery, but the parameters have to be bound with the main query, as @SharkyKZ explained me.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30075.
| Labels |
Added:
?
?
|
||
Oh I overlooked the subquery part thx
Without this PR you get a PHP Warning: mysqli_stmt::bind_param(): Number of variables doesn't match number of parameters in prepared statement in /libraries/vendor/joomla/database/src/Mysqli/MysqliStatement.php on line 420 when using MySQLi. With MySQL (PDO) and PostgreSQL (PDO) you don't get that warning, you only get the error 500 and the empty blog without this PR applied. With this PR it is ok with all 3 DB drivers.
Oh I overlooked the subquery part thx
Same happened to me first ;-)
@Lippy13 Congratulations to your first Pull Request (PR) for Joomla CMS, and thank you for it.
As it has two successful tests, it has status "RTC" now, which means ready to commit. The next step is that a maintainer who was not involved in testing yet (i.e. not me) has again a look on it, and if all ok, what I assume, it will be merged into the 4.0-dev branch and then go into the next 4.0 Beta release after that.
This just as explanation how things are working here in case if you don't know yet.
This PR here has good testing instructions. It would be good if all other PRs had that, too.
So I would be happy to see more PRs from you from time to time, if you find an issue and know how to fix it and have a bit spare time sometimes.
Again thanks for this PR here.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-12 12:38:03 |
| Closed_By | ⇒ | laoneo | |
| Labels | |||
Thanks!
I have tested this item✅ successfully on 029d515
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30075.