Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#30069] - [4.0] Add margins to header title

NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
10 Jul 2020

Summary of Changes

Add top and bottom margins to header title.

Testing Instructions

Apply PR
Run npm i
Log in to administration area
Reduce browser's viewport to mobile

Actual result BEFORE applying this Pull Request

header-no-margin

Expected result AFTER applying this Pull Request

header-margin

avatar Quy Quy - open - 10 Jul 2020
avatar Quy Quy - change - 10 Jul 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Jul 2020
Category ⇒ Administration Templates (admin) NPM Change
avatar infograf768
infograf768 - comment - 11 Jul 2020

@Quy
This PR adds margin top and bottom also when viewport is desktop

BEFORE patch
Screen Shot 2020-07-11 at 06 51 03

AFTER patch
Screen Shot 2020-07-11 at 06 52 39

I suggest to add these margins only when we are in mobile view, i.e. change

    @include media-breakpoint-down(xs) {
      width: 100%;
    }

to

    @include media-breakpoint-down(xs) {
      width: 100%;
      margin-top: 1rem;
      margin-bottom: 1rem;
    }

we will get
headertitle

avatar Quy Quy - change - 11 Jul 2020
Labels Added: NPM Resource Changed ?
avatar Quy
Quy - comment - 11 Jul 2020

Much better! Thanks.

avatar chmst chmst - test_item - 11 Jul 2020 - Tested successfully
avatar chmst
chmst - comment - 11 Jul 2020

I have tested this item ✅ successfully on 5e367b0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30069.

avatar jwaisner jwaisner - test_item - 12 Jul 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 12 Jul 2020

I have tested this item ✅ successfully on 5e367b0

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30069.

avatar jwaisner jwaisner - change - 12 Jul 2020
Status Pending ⇒ Ready to Commit
avatar jwaisner
jwaisner - comment - 12 Jul 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30069.

avatar infograf768
infograf768 - comment - 12 Jul 2020

Restarted drone.

avatar infograf768 infograf768 - close - 12 Jul 2020
avatar infograf768 infograf768 - merge - 12 Jul 2020
avatar infograf768 infograf768 - change - 12 Jul 2020
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-07-12 07:34:13
Closed_By ⇒ infograf768
Labels Added: ?
avatar infograf768
infograf768 - comment - 12 Jul 2020

Tks.

Add a Comment

Login with GitHub to post a comment