Feeling Lucky
?
?
[#30064] - [4.0] A load of general cleanup
- Fixed in Code Base
- 21 Jul 2020
- Medium
- Build: 4.0-dev
- # 30064
- Diff
- PhilETaylor:9july-cleanup
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
A load of general cleanups including, but not limited to
- Mostly work around "Layout variables" commenting
- standardising extract of view data to be above the typehints (as most were)
- remove unused
$appand itsFactoryimport (in layouts/joomla/edit/publishingdata.php) - a/Make thing clear/Layout variables/
- Standardise the length of the
-----------------underLayout variablesheading to be one-more than the chars inLayout variablesas most were already, but some were random length - s/
@param/@varwhere the docs were not params to a method, but inline typehints for IDEs
Testing Instructions
gulp... most are comments only, a few PHP changes but just moving code above/below comments and no real "code" changes so everything should work
Actual result BEFORE applying this Pull Request
everything should work
Expected result AFTER applying this Pull Request
everything should work
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact com_users Layout |
| Labels |
Added:
?
|
||
chmst
- comment
- 11 Jul 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30064.
chmst
- comment
- 11 Jul 2020
Tested a some views but probably not all. Code review looks good. Could you go throug again, @ceford ?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30064.
ceford
- comment
- 11 Jul 2020
I have tested this item
I have been through most of the Admin menu links and not found anything amiss. Also a selection of Site menu items.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30064.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 11 Jul 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30064.
Quy
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-21 03:00:51 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on ac0519a
Applied the patch and went through most of the Admin and Site menu links - no problems encountered.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30064.