Feeling Lucky
?
[#30062] - [4.0] Another [274 file] General Cleanup
- Closed
- 10 Jul 2020
- Medium
- Build: 4.0-dev
- # 30062
- Diff
- PhilETaylor:9july-cleanup
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
A load of general cleanups including, but not limited to
- removing double asterisk from single line inline type hints
- work around "Layout variables" commenting
- standardising extract of view data to be above the typehints (as most were)
- remove a few
?><?php - remove unused
$appand itsFactoryimport (in layouts/joomla/edit/publishingdata.php) - a/Make thing clear/Layout variables/
- Standardise the length of the
-----------------underLayout variablesheading to be one-more than the chars inLayout variablesas most were already, but some were random length - s/
@param/@varwhere the docs were not params to a method, but inline typehints for IDEs
Testing Instructions
gulp... most are comments only, a few PHP changes but just moving code above/below comments and no real "code" changes so everything should work
Actual result BEFORE applying this Pull Request
everything should work
Expected result AFTER applying this Pull Request
everything should work
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_associations com_banners com_cache com_categories |
| Title |
|
||||||
PhilETaylor
- comment
- 10 Jul 2020
Hmm.... I need more coffee... Im wrong apparently. Oh well that's what happens when you code on the day your mum dies. Oh well.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-10 00:25:47 |
| Closed_By | ⇒ | PhilETaylor | |
| Labels |
Added:
?
|
||
brianteeman
- comment
- 10 Jul 2020
I know you had a "challenging" relationship but still sad to hear that news
please look at the code style errors
https://ci.joomla.org/joomla/joomla-cms/33834/1/9