[#30060] - Update loadmodule.php
- Closed
- 23 Dec 2020
- Medium
- Build: staging
- # 30060
- Diff
- nevigen:patch-1
- Success Hound Smells good to me. Woof! Details
- Success Download Prebuilt packages are available for download. Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr Build is passing Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
We should use an utf8 compatible function for replacing
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
substr_replace doesn't work correctly if we have a non-latin characters (characters which takes more than 1 byte, like cyrylic, etc) in our $article->text
As I've said: Provide a reproducible use case, please, if you want to speed up testing. We not only have experts as testers here.
-
Do that
-
Do this
-
Then do that
-
See that it fails
-
Apply patch
-
Test again...
I wonder if we do not have other instances where this change would be welcome.
The same applies to strpos(), right?
yeap
Added the "Updates Requested" label due to necessary changes mentioned in my previous comment.
Would be nice to have unit tests for this plugin. But first we really need testing instructions.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-12-23 09:12:36 |
| Closed_By | ⇒ | nevigen | |
| Labels |
Added:
?
?
|
||
Could you please provide detailed testing instructions (a use case where str_replace fails). Then people can test this change and see why this change is needed. Thank you! You need 2 successful tests by others before a pr cen be merged.