? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
8 Jul 2020

Summary of Changes

  • removed the trailing # in comments, not all comments had them so was inconsistent anyway
  • removed the trailing . in comments
  • Remove blank line
  • added .docker and /docker-compose.yml as some people use official Joomla docker images for testing
  • s/handeling/handling
avatar PhilETaylor PhilETaylor - open - 8 Jul 2020
avatar PhilETaylor PhilETaylor - change - 8 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jul 2020
Category Repository
avatar PhilETaylor PhilETaylor - change - 8 Jul 2020
The description was changed
avatar PhilETaylor PhilETaylor - edited - 8 Jul 2020
avatar Quy Quy - close - 8 Jul 2020
avatar Quy Quy - merge - 8 Jul 2020
avatar Quy Quy - change - 8 Jul 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-07-08 19:23:54
Closed_By Quy
Labels Added: ?
avatar brianteeman
brianteeman - comment - 8 Jul 2020

Just a question for my own education I think but why are some paths with a preceding slash and some not
eg
administrator/language/*
/administrator/components/com_patchtester

avatar PhilETaylor
PhilETaylor - comment - 9 Jul 2020

Pattern format is explained here https://git-scm.com/docs/gitignore

In your example there would be no reason not to have a preceding / to administrator/language/* if the purpose was to exclude the /administrator/language folder

however if the intention was also to exclude /some/other/path/to/administrator/language/ then not preceding it with a / seems right.

A good example is node_modules/. which would not only exclude the root /node_modules but would also exclude any other node_modules folder throughout the webspace.

The gotcha is that if you exclude with a line like log.php this will also exclude ANY file in the webspace with a suffix of log.php including things like Monolog.php

avatar brianteeman
brianteeman - comment - 9 Jul 2020

So thats what I thought it meant

so surely most of the paths should be preceded by a /

avatar PhilETaylor
PhilETaylor - comment - 9 Jul 2020

I cannot speak for the authors of those lines and their intentions at the time, but yes it does seem that some could be, you are right.

Add a Comment

Login with GitHub to post a comment