Open Custom Module screen.
Select OPTIONS tab.
Browse Images to select an image (SELECT) - image 1.
Expect the image to be selectable - it was in J4 Beta 2 for Testing.
Internal Server Error - image 2.
PHP 7.3
J4 Dev 3
Labels |
Added:
Information Required
|
Yes I am selecting an image BEFORE then selecting SELECT button.
And I have just tried again after installing the latest lightly build.
Still see Internal Server Error.
ok I can replicate this (In Firefox, as impossible in Safari due to there being no select button), but with a very specific set of clicks.
If you click the IMAGE then it works fine.
If you DONT CLICK THE IMAGE - but instead SELECT the checkbox in the top left of the image and then click the SELECT button in the modal footer then you replicate the problem.
Nothing is logged as a Ajax request and nothing in the console.log but there is a reproducible problem here.
@dgrammatiko Please see #30045 (comment). Thanks.
@Quy there you go:
For issue #29314 Someone added an overflow: hidden
for the class .input-group-append
, removing it the field is rendered correctly:
If you DONT CLICK THE IMAGE - but instead SELECT the checkbox in the top left of the image and then click the SELECT button in the modal footer then you replicate the problem.
I cannot reproduce the error reported in #29497
Finally the Issue reported here cannot be confirmed as I'm getting a PHP class Folder not found
Super User (The only user) created when installing.
In the root. So url is http://127.0.0.1/
in a docker container with 777 permissions on everything.
In the root. So url is http://127.0.0.1/
Can you attach a fake domain (eg make an alias in the hosts file) so the Ajax request will be http://something.local
as this is something I cannot test on my setup?
If you have 5 mins YOU can go to my local development here: https://97d052c4e6c2.ngrok.io/administrator/
u: admin
p: admin
I'll leave this tunnel up and grab a coffee - let me know if/when you are finished so I can close the tunnel.
@PhilETaylor I still cannot replicate it
Are you too fast on clicking the select button so there might be a race condition as the iframe needs to initialise its js and sync with the parent window?
Very strange.
I thought at first it could be a race condition but Im being deliberately slow (10-15 seconds between each click) and I still get Internal Server Error
when either
Not selecting an image and clicking select to close modal
selecting the checkbox of an image and clicking select to close the modal.
I DONT GET AN ERROR when I click the actual image (as opposed to clicking the checkbox in the top left corner) so there is something different between clicking the actual IMAGE and clicking the checkbox.
same in Firefox so not a safari beta problem :(
so there is something different between clicking the actual IMAGE and clicking the checkbox.
There IS. The images to allow double click have some weird code (I think it's a vue dependency) but what's funny is that we're testing using the same safari...
Ok one last idea: do you have .htaccess enabled? if so can you disable it, clear the browser cache and retry (you might be running an older version of the js script, the .gz)
Its nginx - so no .htaccess :)
nginx has form….
:)
David Robinson
david@redevolution.com
Mobile: 07710 461776
Office: 01224 443551
On 10 Jul 2020, at 11:57, Phil Taylor notifications@github.com wrote:
Its nginx - so no .htaccess :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #30045 (comment), or unsubscribe https://github.com/notifications/unsubscribe-auth/AANOSXN7URQQ2JUW7KNLHRTR23XY3ANCNFSM4OTFTIUQ.
oh hang on - just seen this in the log:
GET /index.php/component/ajax 200 OK
is something routing to the frontend instead of the backend?
that's not the keepalive as that has correct /administrator/:
"system.keepalive": {
"interval": 840000,
"uri": "\/administrator\/index.php?option=com_ajax&format=json"
},
@PhilETaylor I'm out of ideas, the only proper way to figure out there is to place a breakpoint in the com_media controller and inspect what's the input. Might be a problem with csrf or some other data send back to the server
I have an error - one mo...
go here https://97d052c4e6c2.ngrok.io/administrator/index.php?option=com_content&view=article&layout=edit
click select
double click sample data
no idea if that's connected :(
Might be a problem with csrf or some other data send back to the server
Im not seeing any network traffic or Ajax calls :(
Im not seeing any network traffic or Ajax calls :(
OK, we're getting somewhere, Can you attach a fake domain (eg make an alias in the hosts file) as I suggested before. I know it sounds weird but...
Also when I click the checkbox in the top left of an image - the BACKGROUND (the main article edit page, not the modal) moves - like a JS warning/error is being inserted and removed.
The ngrok is a fake domain, when you use that Joomla believes that's the domain its on and all Ajax calls go back to that domain.
I'm guessing you're using docker and I'm using a local server (no vm). There might be some firewall or something else that blocks XHR requests? Nginx probably is not the problem here as I already have a perfectly working instance (sloth-theme.site)
one mo and I'll move to php -S 0.0.0.0:80
outside of docker and outside of nginx
Title |
|
made no difference - same issues.
So this rules out docker. Rules out nginx.
:-(
want another play? https://dd1ca95bb272.ngrok.io
Just to narrow this issue, can you edit:
@dblclick="openPreview()" @mouseleave="hideActions()"
from that line
also change @click.stop="toggleSelect()"
to @click="toggleSelect()"
on
Then recompile with npm install
Done - that FIXES the selection issues :)
It doesnt fix the issue where you click select button to close the modal without ever attempting to select anything.
it doesnt fix double clicking a FOLDER - that still gives a console error
Done - that FIXES the selection issues
It's not an actual fix, we just removed some listeners to narrow down the problem, which turn out to be a race condition between mouse enter/ mouse click
It doesnt fix the issue where you click select button to close the modal without ever attempting to select anything.
That's weird because you've confirmed before that there is an empty object there and the code should handle this correctly
well at least this is some kind of progress :)
@PhilETaylor can you test #30066
It solves the error message when clicking on select without any file selected. The other part on the image clicking misbehaving needs a bit more debugging (also I'm not very familiar with vue, so someone else can fix it faster)
Hi, hope this helps you guys.
I was using default installation of J4 Dev 3 when I reported - and TinyMCE was default content editor.
Today after installing JCE (latest release) I retested Custom Module Background Image. It worked. No Internal Server Error.
When I changed default content editor to any one of NONE, CODEMIRROR, TINYMCE I saw the Internal Server Error message when I tried to add a background image.
Best wishes
IIRC JCE replaces the media browser with one of its own
On 10 Jul 2020, at 13:57, sdrawdenek notifications@github.com wrote:
Hi, hope this helps you guys.I was using default installation of J4 Dev 3 when I reported - and TinyMCE was default content editor.
Today after installing JCE (latest release) I retested Custom Module Background Image. It worked. No Internal Server Error.
When I changed default content editor to any one of NONE, CODEMIRROR, TINYMCE I saw the Internal Server Error message when I tried to add a background image.
Best wishes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
@sdrawdenek please test #30066
#30066 fixes the issue where you click select button to close the modal without ever attempting to select anything.
which is Issue #29497
#30066 fixes Error message shown when clicking the checkbox and then select button to close modal
which is this issue #30045
#30066 doesnt fix When using the checkbox to select an image, and then clicking the select button to close model, no image is actually selected in the page
#30066 doesnt fix when double clicking on a folder in media manager I get TypeError: undefined is not an object (evaluating 'this.$refs.actionToggle.focus')
The last 2 are definitely associated with the media manager app (the vue js code)
I guess, for clarity, we should ask @sdrawdenek to close this issue (as its resolved by #30066), and open a new issue for the two remaining problems?
Also can I say a big thank you - without your help today these issues would have dragged on, we needed an expert :) and I stick to jQuery ;-) ;-)
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-12 09:30:05 |
Closed_By | ⇒ | sdrawdenek |
Unable to reproduce. Please try testing with the nightly builds. https://developer.joomla.org/nightly-builds.html