[#30043] - [4.0] [cosmetics] Remove variable type mixing in display controller / view
- Fixed in Code Base
- 2 Jan 2021
- Medium
- Build: 4.0-dev
- # 30043
- Diff
- degobbis:jdev/ftpCredentialsInView
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
A better way to set the FTP credentials for the view
1. we should define the property in the view in which we want to fill it later
2. we should use the set method from the base class to set a value
3. the marking as a reference is no longer necessary
After further research it seems that the variable $this->ftp holding the return value of the setCredentialsFromRequest() method is not used and / or directly overwritten in the associated view with the FTP credentials from the model.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
| Labels |
Added:
?
|
||
| Title |
|
||||||
I have tested this item
Looks good on code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30043.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30043.
I want a practical test of this too please as it covers Joomla Update. Code review is good enough for one test but not both
@richard67 @wilsonge
For testing we need an older NightlyBuild to exerzise an Joomla update, where I can get one?
While playing through the test instruction I noticed that a test is very complex and not easy to do.
Since the FTP credentials were implemented as a workaround for the wwwrun problem on web servers, such a server is necessary for a reliable test.
Already the installation of Joomla on such a server is the first hurdle.
At least two installations are necessary, because resetting the installation after the update is not so easy and could falsify the result because of the file permissions.
Do we have professionals who could test this?
There is another PR dealing with Joompaupdate Upload & Update and FTP: #28029 . Maybe the author, @twister65 can help with testing here? Or maybe @Quy can do?
Quy
- | Status | Ready to Commit | ⇒ | Pending |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-01-02 05:20:55 |
| Closed_By | ⇒ | wilsonge |
OK Doesn't look like we'll get testers :/ Thanks
I have tested this item✅ successfully on e57dc08
Code inspect, looks good.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30043.