[#30038] - [4.0] Fix Cassiopea Modals body and Close button display
- Fixed in Code Base
- 10 Jul 2020
- Medium
- Build: staging
- # 30038
- infograf768:4.0_cassiopea_modal
Summary of Changes
Correcting wrong body padding.
Therefore correcting wrong Close button padding and margin to display as square
Both body and close button will now display as in back-end
Testing Instructions
Display any modal in frontend, for example through CMS Content when editing an article OR editing Template settings and Select Image
Actual result BEFORE applying this Pull Request
Example below is for Image Select in Template settings
Close button detail
Expected result AFTER applying this Pull Request
Image below is for CMS Content =>Image
Close button detail
I applyed the code manually, run npm ci and tested successfully. Header in modal is now fine.
RTC done here as the PR is not present in issues.
rdeutz
- | Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-10 09:25:08 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) NPM Change |
does this not then break article selection lists for example when selecting an article when creating a menu item? Cant test as on the road, but ALL modals could be affected by this change and so other types of modal needs to be checked too.
Tested successfully.