Feeling Lucky
?
?
[#30036] - [4] Don't interrupt getCoreList() if single template has no /html/
- Fixed in Code Base
- 11 Jul 2020
- Medium
- Build: 4.0-dev
- # 30036
- Diff
- ReLater:patch-2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Fixes #30035
Summary of Changes
- Don't interrupt
getCoreList()at all if single template has no/html/folder. Simply go on.
Testing Instructions
-
Activate plugin
Installer - Override -
Install this remplate: [Link removed 2020-07-11 after request of shor-ty] (provided by @shor-ty).
This template has no /html/-folder in package. -
Hint: Uninstall template before each new test (it has no
method="update").
Actual result BEFORE applying this Pull Request
- Plugin
Installer - Overrideprovokes an error messageCOM_TEMPLATES_ERROR_TEMPLATE_FOLDER_NOT_FOUNDby calling method getCoreList() that can't find folder /html/ in new template. COM_TEMPLATES_ERROR_TEMPLATE_FOLDER_NOT_FOUNDis wrong here because it says that the template folder wasn't found. That's not true.
Expected result AFTER applying this Pull Request
- There is no need to stop searching for overrides in other templates just because a single template has no html folder.
- No error message during installation.
Documentation Changes Required
- No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_templates |
| Title |
|
||||||
ChristineWk
- comment
- 6 Jul 2020
OK, uninstalled it & installed again :-)
ChristineWk
- comment
- 6 Jul 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30036.
Quy
- comment
- 6 Jul 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30036.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 6 Jul 2020
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30036.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-11 12:33:36 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
?
|
||
richard67
- comment
- 11 Jul 2020
Thanks!
4.0.0-dev3 JUL6th2020
Before Patch:
a) confirm error message
b) Control Panel: "Update Checks" shows a red icon > No.
Applied Patch:
Warning
Extension Install: Another template is already using the named folder: /home/my site/templates/holzmanncfd. Are you trying to install the same extension again?
Error
Error installing template
Will try to get rid of above, to start again.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30036.