[#30025] - [4.0] Fix for wrong site title when using ToobarHelper in frontend
- Fixed in Code Base
- 10 Jul 2020
- Medium
- Build: 4.0-dev
- # 30025
- Diff
- Didldu-Florian:patch-5
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Site title "- Administration" should only be added at administrator.
This happens when component developers use the toolbar helper in the frontend
Testing Instructions
Using Toolbar Helper in a Frontend Compoennt and check the site title.
You can test it by changeing article view like these
4.0-dev...Didldu-Florian:patch-6
Open then an article in frontend, you will see then the problem in the <title>
Actual result BEFORE applying this Pull Request
The site title ist looking like these at frontend:
<title>Home - JADMINISTRATION</title>
Expected result AFTER applying this Pull Request
<title>Home</title>
The Problem is also that the language key JADMINISTRATION is not translated either.
So finaly we should not add "- JADMINISTRATION" at frontend.
This fix does this
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Title |
|
||||||
It's fixed
@Didldu-Florian Yes, I've noticed. Do we have some component in core we can use for testing? Or do you have some 3rd party component you can tell?
@richard67 in core not, but you can test it by by changing article view
4.0-dev...Didldu-Florian:patch-6
Open then an article in frontend, you will see then the problem in the <title>
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30025.
@richard67 See link on to do multi-line comments/edits: https://twitter.com/github/status/1179101186437324801
It is an outdated post, but applies to suggestions too. I have done it. Give it a try and you will see.
I have tested this item
I've added the code in com_content and see JADMINISTRATOR in title. After apply the path I don't see that word in title.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30025.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30025.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-10 16:10:32 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
Tks.
It's fixed