[#30022] - [4.0] Fix translation of message titles in Cassiopea
- Fixed in Code Base
- 11 Jul 2020
- Medium
- Build: 4.0-dev
- # 30022
- Diff
- infograf768:4.0_messagetitles
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #30009
Summary of Changes
Adding the javascript strings in index.php. Thanks @brianteeman
Chose index.php instead of specific views to not bother anymore.
We use the same trick for installation/index.php
Testing Instructions
See #30009
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
Maybe add this to layouts/joomla/system/message? Otherwise it's also needed in template's component.php.
I have tested this item
Works as described. Noted question about where it ought to be located. In German the pink error message says:
Fehler
The form cannot be submitted as it's missing required data.
Please correct the marked fields and try again.
And in French:
Erreur
The form cannot be submitted as it's missing required data.
Please correct the marked fields and try again.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30022.
| Labels |
Added:
?
|
||
| Category | Front End Templates (site) | ⇒ | Layout |
Note:
Could we now get rid of redundant stuff? just checked for ERROR, but they contain more
administrator/components/com_config/tmpl/application/default_mail.php:23: Text::script('ERROR');
administrator/components/com_config/tmpl/application/default.php:21: Text::script('ERROR');
administrator/components/com_config/tmpl/component/default.php:21: Text::script('ERROR');
administrator/components/com_cpanel/tmpl/cpanel/default.php:19: Text::script('ERROR');
administrator/components/com_installer/tmpl/install/default.php:18: Text::script('ERROR');
administrator/components/com_menus/tmpl/item/edit.php:21: Text::script('ERROR');
administrator/components/com_menus/tmpl/menu/edit.php:21: Text::script('ERROR');
administrator/modules/mod_login/tmpl/default.php:27: Text::script('ERROR');
installation/template/index.php:36: Text::script('ERROR');
layouts/joomla/edit/associations.php:22: Text::script('ERROR');
layouts/joomla/form/field/rules.php:65: Text::script('ERROR');
layouts/joomla/toolbar/batch.php:22: Text::script('ERROR');
layouts/plugins/user/token/token.php:26: Text::script('ERROR');
libraries/src/Toolbar/Button/ConfirmButton.php:79: Text::script('ERROR');
libraries/src/Toolbar/Button/StandardButton.php:137: Text::script('ERROR');
plugins/quickicon/extensionupdate/extensionupdate.php:72: Text::script('ERROR');
plugins/quickicon/joomlaupdate/src/Extension/Joomlaupdate.php:111: Text::script('ERROR');
probably
I have tested this item
Looks like it moved to layouts/joomla/system/message.php. I guess the untranslated message part (in German and French) is a separate issue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30022.
Looks like it moved to layouts/joomla/system/message.php. I guess the untranslated message part (in German and French) is a separate issue.
Not an issue. The German and French language packs are J3 packs and there are many changes in J4 concerning strings (added ad deleted).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30022.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30022.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-11 12:40:16 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
Thanks!
So every template provider must add these language keys?