[#30011] - [4.0] Show error message when restoring version fails
- Fixed in Code Base
- 6 Jul 2020
- Medium
- Build: 4.0-dev
- # 30011
- Diff
- SharkyKZ:j4/impr/history-restore
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Show a message when restoring history version fails.
Testing Instructions
Create an article.
Make some edits to create multiple versions.
Click Versions button.
In the modal select a version and click Restore.
Actual result BEFORE applying this Pull Request
Version is not restore but success message is shown.
Expected result AFTER applying this Pull Request
Error message is shown:
Error
Column 'ordering' cannot be null
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30011.
This is confusing for me. I created an article with one line, saved, added a line, saved, added a line saved. So I have three Versions.
Question: why does it let me choose more than one version and put up an alert to tell me to select One version?
It is the first version that says it has saved but hasn't - so the patch works. But why can't I restore the first version? And what on earth do I do about Error: Column 'ordering' cannot be null. It seems to me there ought to be a better solution.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30011.
@ceford see: https://issues.joomla.org/tracker/joomla-cms/30006
I have tested this item
Tested successfully in Beta3-dev of 6 July. After the column 'ordering' was set to Null, the results were as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30011.
I have tested this item
Tested successfully in Beta3-dev of 6 July. After the column 'ordering' was set to Null, the results were as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30011.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30011.
| Labels |
Added:
?
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-06 13:23:48 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
Thanks!
This is confusing for me. I created an article with one line, saved, added a line, saved, added a line saved. So I have three Versions.
Question: why does it let me choose more than one version and put up an alert to tell me to select One version?
It is the first version that says it has saved but hasn't - so the patch works. But why can't I restore the first version? And what on earth do I do about Error: Column 'ordering' cannot be null. It seems to me there ought to be a better solution.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30011.