?
avatar PhilETaylor
PhilETaylor
5 Jul 2020

Steps to reproduce the issue

Install Joomal 4.0-dev @ 1f24603
Login to super admin
Click Install next to Blog Sample Data
Click ok in JS popup

Go to front end and

Login as super admin

click Welcome to your blog
Click cog -> click edit (to edit the article)

click Versions button

Expected result

Styled modal

Actual result

The modal loads, but without assets, so looks unstyled
All the assets are 404 as they are appended to the url and dont use the correct base URL.

Screenshot 2020-07-05 at 16 14 06

System information (as much as possible)

safari on Mac

YES! I have blown away REPEATEDLY my install and reinstalled and recompiled assets many times to resolve this issue but still it persists.

Additional comments

I also saw this earlier too on the frontend again when trying to change the template logo by using the sample content Template Settings link, but then I thought that resolved itself... very very strange.

Screenshot 2020-07-05 at 15 12 44

avatar PhilETaylor PhilETaylor - open - 5 Jul 2020
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jul 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 5 Jul 2020
avatar PhilETaylor
PhilETaylor - comment - 5 Jul 2020

The problem is that the iframe src is not prefixed with the correct path when using SEF

The src should start with a /

 <iframe class="iframe" src="index.php?option=com_contenthistory&amp;view=history&amp;layout=modal&amp;tmpl=component&amp;field=jform_contenthistory&amp;item_id=com_content.article.3&amp;9e389e2a5c6f59784b8e730bd71c35a7=1" name="Versions" title="Versions" height="100%" width="100%"></iframe>
avatar PhilETaylor PhilETaylor - change - 5 Jul 2020
Title
[4.0] frontend modals missing all assets - did someone remove the base tag?
[4.0][RELEASE BLOCKER] frontend modals missing all assets - did someone remove the base tag?
avatar PhilETaylor PhilETaylor - edited - 5 Jul 2020
avatar PhilETaylor
PhilETaylor - comment - 5 Jul 2020

Another example.

Enable SEF with SEF rewrite this time. (Issues above were with standard SEF on Rewrite off)

Login to frontend as super admin

Edit a module

note url of edit page is

http://127.0.0.1/index.php?option=com_config&view=modules&id=16&Itemid=101&return=aHR0cDovLzEyNy4wLjAuMS9jb21wb25lbnQvY29uZmlnP3ZpZXc9bW9kdWxlcyZpZD0xJnJldHVybj1hSFIwY0Rvdkx6RXlOeTR3TGpBdU1TOD0%3D

Just click save

notice url is now different AND notice the console log message with a 404

url now:
http://127.0.0.1/component/config?view=modules&id=16&return=aHR0cDovLzEyNy4wLjAuMS9jb21wb25lbnQvY29uZmlnP3ZpZXc9bW9kdWxlcyZpZD0xJnJldHVybj1hSFIwY0Rvdkx6RXlOeTR3TGpBdU1TOD0=

404 trying to load following url (as it has /component/in it incorrectly)

http://127.0.0.1/component/index.php?option=com_modules&task=module.orderPosition&8436244716061d6595485618fb70d7c5=1&client_id=0&position=sidebar-right

avatar brianteeman
brianteeman - comment - 5 Jul 2020

Tested with SEF in all three modes and cannot replicate this in any of them

SEF OFF
SEF ON
SEF ON With URL rewriting

avatar PhilETaylor
PhilETaylor - comment - 5 Jul 2020

And what we server? Apache ? Nginx?

Sent from my iPhone

On 5 Jul 2020, at 17:57, Brian Teeman notifications@github.com wrote:


Tested with SEF in all three modes and cannot replicate this in any of them

SEF OFF
SEF ON
SEF ON With URL rewriting


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

avatar brianteeman
brianteeman - comment - 5 Jul 2020

Apache/2.4.41 (Win64) mod_fcgid/2.3.10-dev

avatar chmst
chmst - comment - 5 Jul 2020

All works fine for me
Apache/2.4.43 (Win64) OpenSSL/1.1.1g PHP/7.4.6 Server at localhost Port 80
in firefox and edge


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29998.

avatar PhilETaylor
PhilETaylor - comment - 5 Jul 2020

I believe it might be a nginx issue.

I have blown away and started from scratch multiple times using my nginx development docker platform (which I use daily for all the other reports).

If I hook up the same files with the php -S 0.0.0.0:80 development web server I cannot replicate the problem.

avatar PhilETaylor
PhilETaylor - comment - 5 Jul 2020

Actually - I take that back. INSPECT YOUR REQUESTS and you will see they are wrong - but work. This is what I get with a php -S 0.0.0.0:80 server when I press the versions button

Screenshot 2020-07-05 at 18 31 06

Look carefully at the URL in green. note the /index.php/index.php?

Do you have that on yours? If so this is invalid (even though it works for you).

avatar brianteeman
brianteeman - comment - 5 Jul 2020

Do you have that on yours? If so this is invalid (even though it works for you).

No

image

avatar PhilETaylor
PhilETaylor - comment - 5 Jul 2020

Stranger and stranger. Yours could be affected by a sub folder.

I get /index.php/index.php? with both Nginx and the PHP Development server which rules out nginx.

avatar PhilETaylor
PhilETaylor - comment - 5 Jul 2020

linking #29990 as that's defo related to this one.

avatar PhilETaylor
PhilETaylor - comment - 5 Jul 2020

Im now on a totally different computer - my laptop

Git checkout
jinstall which is rm -rf administrator/templates/atum/css; rm -rf templates/cassiopeia/css; rm -rf media/; rm -rf node_modules/; rm -rf libraries/vendor/; composer install; npm ci; git checkout -- libraries/vendor/.htaccess
docker-compose up (gives me Nginx/mysql8/php7.4.7)
install as normal
login to admin - install sample data
login to frontend - click template settings - click select

Screenshot 2020-07-05 at 18 51 27

Im at a loss ...

avatar PhilETaylor
PhilETaylor - comment - 5 Jul 2020

Ok apache seems to be working for Versions in Chrome and Safari

but for Template Settings select image, with apache, I get a JS issue in Chrome only (not safari) when using apache

Screenshot 2020-07-05 at 19 32 16

avatar PhilETaylor
PhilETaylor - comment - 5 Jul 2020

regardless, the getting of /index.php/index.php? in urls seems to be the root issue here, as the "root" is not correct and thus assets are getting loaded from the wrong place. Replicated on two different Macs with totally different configs. Im stepping away (need to be a dad) and will look again from a third computer in the morning.

avatar PhilETaylor
PhilETaylor - comment - 5 Jul 2020

PR incoming... found the issue... fixed the issue.

avatar PhilETaylor PhilETaylor - close - 5 Jul 2020
avatar PhilETaylor PhilETaylor - change - 5 Jul 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-07-05 20:24:09
Closed_By PhilETaylor

Add a Comment

Login with GitHub to post a comment