?
avatar PhilETaylor
PhilETaylor
5 Jul 2020

Steps to reproduce the issue

Install Joomal 4.0-dev
Login to super admin
Click Install next to Blog Sample Data
Click ok in JS popup

Go to front end and

Login as super admin

click Template Settings menu item

Expected result

Save and cancel buttons with correct background colour and correct icon colour distinguishable from the background colour

Actual result

Screen Recording 2020-07-05 at 03 04 PM

System information (as much as possible)

Safari on Mac

Joomla 4.0-dev @ 1f24603

avatar PhilETaylor PhilETaylor - open - 5 Jul 2020
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jul 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 5 Jul 2020
avatar brianteeman
brianteeman - comment - 5 Jul 2020

Can not replicate Chrome on Windows

image

avatar PhilETaylor
PhilETaylor - comment - 5 Jul 2020

well I can even see the CSS that has a green color when inspected safari and chrome on Mac:

Screenshot 2020-07-05 at 18 33 58

Screenshot 2020-07-05 at 18 36 11

which comes from css/blocks/_icons.scss

Screenshot 2020-07-05 at 18 37 56

avatar brianteeman
brianteeman - comment - 5 Jul 2020

found the "problem"

With debug on - ie it is loading the non minified assets then I see the class

Can you check and see if the problem "goes away" with debug off using the minified assets

avatar PhilETaylor
PhilETaylor - comment - 5 Jul 2020

totally different computer (now on the laptop) and I get the same

Screenshot 2020-07-05 at 18 47 51

These are all fresh installs from git, with jinstall asset build and then straight install - no debug mode.

One of my chrome screenshots above shows that its using template.mi... so assume that's the minified assets

avatar chmst
chmst - comment - 5 Jul 2020

Confirmed for firefox and edge on win10 (debugging is on)
tinyMCE-frontend-buttons-colours

avatar infograf768
infograf768 - comment - 6 Jul 2020

Firefox Macintosh. Debug off or on. Can confirm.
Same issue for Cancel which has a red icon

.fas.fa-times, .icon-unpublish {
    color: #d9534f;
}

Same indeed when editing an article.

Or we choose btn-secondary (which has a white background, effect similar to backend), or we modify the icon colour to white. In the second case we would need a specific colour for Save & Close

avatar infograf768
infograf768 - comment - 6 Jul 2020

Using btn-secondary would give
Screen Shot 2020-07-06 at 08 06 55

avatar infograf768
infograf768 - comment - 6 Jul 2020

@coolcat-creations
What do you think?

avatar SharkyKZ
SharkyKZ - comment - 7 Jul 2020

Would be great if we didn't apply custom styling using generic icon selectors.

avatar N6REJ
N6REJ - comment - 2 Aug 2020

all that is needed is to apply .text-white to the buttons that have non-white background as I discussed with @chmst

avatar N6REJ N6REJ - change - 4 Aug 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-08-04 18:35:34
Closed_By N6REJ
avatar N6REJ N6REJ - close - 4 Aug 2020
avatar N6REJ
N6REJ - comment - 4 Aug 2020

pr #30278

Add a Comment

Login with GitHub to post a comment