@infograf768 do you think it would be better to use auto instead of static size?

Doesn't look like the right solution. The issue here is that icon-color-featured class is applied twice:

icon is set by:

jgrid.isdefault is a function from:

and that one calls static::state from the same file:

and that one calls static::action from the same file:

In that last function the magic happens.
the $active_class is set to both the anchor as the span inside that anchor.
$active_class="icon-color-featured fas fa-star"

I agree with @SharkyKZ that css is not the right solution. Changing the variables in the PHP should do the trick.
@N6REJ can you do that?

@hans2103 not sure what should change. Would you mind making a pr for that? Or correcting this pr?

@SharkyKZ the css fix was needed because they used different px sizing. When elaine did the whole color-featured thing I thought it was weird but she's the design person not me.
And of course the fa- should match icon- which it didn't.

I haven't tried npm, but with only PR application the stars aren't cheered.
With the inspection of HTML you have this code

The first tag open is from the yellow star and the other is from the grey star.

@Quy @hans2103 @SharkyKZ Thanks for the fixes.. Got it all squared away now.

Please fix.

Please fix.

what in the world!!!!!!

I can reproduce the issue.

before applying PR

and running npm build:css

after applying PR

and running npm build:css

@N6REJ your suggested changes to fix styling on the default star have some negative effect on the styling of all icons on the website so it seems. :-)
Back to the drawing table I guess

@N6REJ your suggested changes to fix styling on the default star have some negative effect on the styling of all icons on the website so it seems. :-)
Back to the drawing table I guess

thats what I'm looking @.. it's doing it even in 4.0-dev branch on my end but I'm going to test things more carefully

not my bug ?
running composer install then npm ci on fresh pull of 4.0-dev fixed it.

as you can see all the broken icons were changed recently..

@N6REJ then please merge most recent changes of branch 4.0 dev into your pull request and check again.

@hans2103 exactly what I did, as I explained. Here you can see that I've done so.

https://youtu.be/j-4Rqk2UQhs
Pushed AFTER this video cause I forgot to during it.

@N6REJ please point me where you run npm build:css after applying your changes.
See my video where I run npm build:css both before and after applying your changes
https://www.youtube.com/watch?v=BB6NEX06n_k

@hans2103 I don't.. I ran npm ci !
Nice trick with storm & npm module on left. How'd you get a npm module like that?
I'm going to try a pre-built package and see if that works or not. I'm also going to do my best to find out exactly why PT isn't working.
I haven't tried it with PT.

@hans2103 idk whats wrong with my local system but I can confirm that my pr is currently broken using the pre-built.
what I don't understand is why it works fine locally.
I've got storm set to the pr branch

and you can see its fine...

Here's my install..
https://hallhome.us/joomla-cms.zip
@richard67 @roland-d any clue whats going on?
back to the drawing board for me... sigh

Nice trick with storm & npm module on left. How'd you get a npm module like that?

PHP Storm > right mouse click on file package.json and select option "Show NPM Scripts"

@Quy @hans2103 @richard67
I'm happy to report I FINALLY found the cause. I'm so sorry for having such a crappy pr.
I'll be much more careful in the future. I couldn't see the error on chrome but it was very clear in FF-Dev.

I have tested this item ✅ successfully on cc41d1e

I have tested this item ✅ successfully on cc41d1e

rtc

Tks.