[#29976] - [4.0] Modal footer buttons
- Closed
- 2 Aug 2020
- Medium
- Build: 4.0-dev
- # 29976
- Diff
- brianteeman:id4
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
This PR changes the order of the modal footer buttons so that they are in the same order as the toolbar buttons ie Save, Save & Close, Close
This PR also changes the class from btn-primary to btn-success for the Save & Close button to match the toolbar colour
Any other changes to the code or codestyle are beyond the scope of this PR
Pull Request for Issue #29560 .
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_cpanel com_menus com_newsfeeds com_redirect |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29976.
@ceford is right but the issue is general
If we want to mock up toolbar for the Close button
Instead of
<button type="button" class="btn btn-secondary"'
we should have
<button type="button" class="btn btn-danger'
EDIT:
But we have a confusion between Cancel, Close and Delete in all admin.
for Cancel and Close, btn btn-secondary looks fine to me, including in toolbar.
for Delete or similar buttons. btn-danger looks correct
Btw, Menus Module edit has btn-danger in this patch.
`
I specified in the pr exactly what the scope of the pr was and yet you chose to derail it with comments about unrelated things - shame
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-02 19:59:27 |
| Closed_By | ⇒ | brianteeman |
The Order is OK but I noticed that the Close button is White / Dark Grey. In Users / Edit Group, for example, the Toolbar Close button is White / Red.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29976.