?
avatar PhilETaylor
PhilETaylor
4 Jul 2020

Steps to reproduce the issue

Joomla 4 admin console
When you login and there are Post Installation Messages there is a number next to the icon in the header

Expected result

Expect that number to be cached and not to generate additional sql queries on every single page load

Actual result

On every single admin page load there are additional sql queries to check the post install message conditions.

Example with "Two Factor Authentication is Available" message which calls twofactorauth_postinstall_condition function on every page load

Screenshot 2020-07-04 at 11 44 35

ok so 441μs is not a lot - but this can multiply if there are a lot of conditions to check and is just another mysql query that is not needed to run on each and every page load.

avatar PhilETaylor PhilETaylor - open - 4 Jul 2020
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 4 Jul 2020
avatar chmst
chmst - comment - 4 Jul 2020

Related to #29702


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29950.

avatar SharkyKZ
SharkyKZ - comment - 18 Aug 2020

Maybe messages could be disabled (hidden) in the database once their conditions are met?

avatar alikon
alikon - comment - 18 Aug 2020

please test #30409

avatar alikon
alikon - comment - 18 Aug 2020

i'll not close this issue for now..... i'll wait for some more feedback
cause i think more can be done/cached

avatar alikon
alikon - comment - 26 Apr 2021

please test #33344

avatar alikon alikon - change - 26 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-26 17:21:46
Closed_By alikon
avatar alikon alikon - close - 26 Apr 2021
avatar PhilETaylor
PhilETaylor - comment - 26 Apr 2021

#33344 doesn't fix this.

It needs to be implemented as an ajax call like the other badges, so that it can be cached and can also only check periodically. and not have to process all the post installation conditions on every page load ever. Thats simply just a waste.

avatar PhilETaylor
PhilETaylor - comment - 26 Apr 2021

For example see this - #32995 this SQL runs on EVERY page of the admin console.

@alikon Please reopen.

@YatharthVyas a good try though.

avatar alikon
alikon - comment - 26 Apr 2021

sure

avatar alikon alikon - change - 26 Apr 2021
Status Closed New
Closed_Date 2021-04-26 17:21:46
Closed_By alikon
avatar alikon alikon - reopen - 26 Apr 2021
avatar PhilETaylor
PhilETaylor - comment - 26 Apr 2021

actually this and #32995 are the same thing. reported almost a year apart - so maybe close this one after all and leave #32995 open :)

avatar PhilETaylor PhilETaylor - change - 26 Apr 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-04-26 17:39:12
Closed_By PhilETaylor
avatar PhilETaylor PhilETaylor - close - 26 Apr 2021

Add a Comment

Login with GitHub to post a comment