User tests: Successful: Unsuccessful:
Pull Request for Issue # .
#29903
fixed wrong variable name/function for pre-classed icons
go to template styles & verify there are no errors.
https://user-images.githubusercontent.com/1296369/86364027-9119cb80-bc6f-11ea-9e31-b77bbb14bb2a.png
https://user-images.githubusercontent.com/1296369/86364027-9119cb80-bc6f-11ea-9e31-b77bbb14bb2a.png
none
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
It is hard to see from your screenshot but it looks like the file you are editing is the css and not the scss file
If you meant that you edited the _icons.scss file as in the second image result and then the result after npm was as you showed in the first image. Then I just did that and the resulting css was 14px
One possible solution for the star position is an override
diff --git a/administrator/templates/atum/scss/vendor/fontawesome-free/fontawesome.scss b/administrator/templates/atum/scss/vendor/fontawesome-free/fontawesome.scss
index 760ebd6..f4febcb 100644
--- a/administrator/templates/atum/scss/vendor/fontawesome-free/fontawesome.scss
+++ b/administrator/templates/atum/scss/vendor/fontawesome-free/fontawesome.scss
@@ -16,2 +16,8 @@
float: left;
}
+
+[class^="icon-"]:not(.input-group-text),
+[class*=" icon-"]:not(.input-group-text) {
+ width: auto;
+ height: auto;
+}
up
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-04 16:06:21 |
Closed_By | ⇒ | infograf768 | |
Labels |
Added:
?
?
|
@infograf768 test with your component please.