? ? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
3 Jul 2020

Pull Request for Issue # .
#29903

Summary of Changes

fixed wrong variable name/function for pre-classed icons

Testing Instructions

go to template styles & verify there are no errors.
https://user-images.githubusercontent.com/1296369/86364027-9119cb80-bc6f-11ea-9e31-b77bbb14bb2a.png

Actual result BEFORE applying this Pull Request

https://user-images.githubusercontent.com/1296369/86364027-9119cb80-bc6f-11ea-9e31-b77bbb14bb2a.png

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

none

avatar N6REJ N6REJ - open - 3 Jul 2020
avatar N6REJ N6REJ - change - 3 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2020
Category Libraries
avatar N6REJ
N6REJ - comment - 3 Jul 2020

@infograf768 test with your component please.

avatar brianteeman brianteeman - test_item - 3 Jul 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 3 Jul 2020

I have tested this item successfully on d553f24


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29933.

avatar Quy Quy - test_item - 3 Jul 2020 - Tested successfully
avatar Quy
Quy - comment - 3 Jul 2020

I have tested this item successfully on d553f24


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29933.

avatar Quy Quy - change - 3 Jul 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 3 Jul 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29933.

avatar Quy
Quy - comment - 3 Jul 2020

@N6REJ Can you see why the icons under Default is not centered? Thanks.

29933

avatar N6REJ
N6REJ - comment - 3 Jul 2020

@Quy
[class*=" icon-"]:not(.input-group-text), [class^=icon-]:not(.input-group-text) has a different fontsize (14px) then
.tbody-icon [class*=" fa-"], .tbody-icon [class*=" icon-"], .tbody-icon [class^=fa-], .tbody-icon [class^=icon-] (26px)
I think @Eighke was working on the css?

avatar N6REJ
N6REJ - comment - 3 Jul 2020

@Quy
image
and
image
need to happen but every time I do & run npm ci, fontawesome is reverted to 14px.

avatar brianteeman
brianteeman - comment - 3 Jul 2020

It is hard to see from your screenshot but it looks like the file you are editing is the css and not the scss file

avatar brianteeman
brianteeman - comment - 3 Jul 2020

If you meant that you edited the _icons.scss file as in the second image result and then the result after npm was as you showed in the first image. Then I just did that and the resulting css was 14px

avatar infograf768
infograf768 - comment - 4 Jul 2020

@N6REJ This PR does not have any unwanted consequences on my component.

avatar infograf768
infograf768 - comment - 4 Jul 2020

One possible solution for the star position is an override

diff --git a/administrator/templates/atum/scss/vendor/fontawesome-free/fontawesome.scss b/administrator/templates/atum/scss/vendor/fontawesome-free/fontawesome.scss
index 760ebd6..f4febcb 100644
--- a/administrator/templates/atum/scss/vendor/fontawesome-free/fontawesome.scss
+++ b/administrator/templates/atum/scss/vendor/fontawesome-free/fontawesome.scss
@@ -16,2 +16,8 @@
   float: left;
 }
+
+[class^="icon-"]:not(.input-group-text),
+[class*=" icon-"]:not(.input-group-text) {
+  width: auto;
+  height: auto;
+}

which gives
Screen Shot 2020-07-04 at 08 56 19

avatar infograf768
infograf768 - comment - 4 Jul 2020

up

avatar infograf768 infograf768 - change - 4 Jul 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-07-04 16:06:21
Closed_By infograf768
Labels Added: ? ?
avatar infograf768 infograf768 - close - 4 Jul 2020
avatar infograf768 infograf768 - merge - 4 Jul 2020
avatar infograf768
infograf768 - comment - 4 Jul 2020

Tks. I'm merging this now as it is RTC. I will reeopen #29957 so that we do not forget to try to solve the alignment issue.

Add a Comment

Login with GitHub to post a comment