[#29930] - [POC] Jlayout for list field
- Closed
- 21 Jul 2022
- Medium
- Build: staging
- # 29930
- Diff
- degobbis:jlayoutForListField
- Success Hound Smells good to me. Woof! Details
- Success Download Prebuilt packages are available for download. Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Success continuous-integration/drone/pr Build is passing Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Code adapted for the use of JLayout. The field can than be overwritten using a layout file.
cc @zero-24
Addition:
If we assume this PR, we can remove the overrides in all fields that depends on this one.
They all then use the layout renderer method of this field.
I will gladly make the adjustments of dependend fields in a separate PR if this change is accepted.
Testing Instructions
Go into Joomla backend and select Menus->Main menu
Actual result BEFORE applying this Pull Request
The list field for filtering (or each other list field), works and looks as expected.
Expected result AFTER applying this Pull Request
The list field for filtering (or each other list field), works and looks as expected.
Nothing breaks.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Libraries |
| Labels |
Added:
?
|
||
@degobbis tried some filter after selecting: Menus->Main menu (they were OK) - don't know which you mean exactly.
@ChristineWk Thx for testing.
For a better understanding I have extended the test instruction a little
| Title |
|
||||||
J4 already have it, I hope you copied this one from J4 https://github.com/joomla/joomla-cms/blob/4.0-dev/layouts/joomla/form/field/list.php :)
Then this is okay
Not exactly, because the layout in J4 does not quite match the processing of the field in J3.
But I have transferred the generation from the list field into a separate layout file.
The trevis-ci test crashes on this line:
https://github.com/joomla/joomla-cms/blob/3.10-dev/libraries/joomla/session/handler/native.php#L235
Comming from here:
https://github.com/joomla/joomla-cms/blob/3.10-dev/libraries/cms/html/category.php#L48
Startet from this call:
https://github.com/joomla/joomla-cms/blob/3.10-dev/libraries/legacy/form/field/category.php#L65
When I tested it on the staging or 3.10-dev branch, without a PR, it also crashes on the same line.
Is someone here that has an idea how to fix it?
I have tested this item
No problems found, works fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29930.
| Labels |
Added:
?
Removed: ? |
||
Hi @degobbis I'm sorry that this has never been merged into the J3 series. While I was involved in the initial thought process building up to this PR. I agree now that this PR should not be merged into J3. I understand and remember our thoughts but I'm not intending to change the behavior now with the last regular release of J3
Thanks for the PR and thanks for understanding
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-07-21 17:25:10 |
| Closed_By | ⇒ | zero-24 |
I have tested this item✅ successfully on b43f6af
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29930.
@degobbis tried some filter after selecting: Menus->Main menu (they were OK) - don't know which you mean exactly.