No Code Attached Yet
avatar angieradtke
angieradtke
3 Jul 2020

What needs to be fixed

The accordion view is still using tab-aria syntax . This is wrong.

Why this should be fixed

Wrong usage , 1Ally
Suggestion: Anker can be a button but this leads to styling issues.

How would you fix it

Index: libraries/src/HTML/Helpers/Bootstrap.php

@@ -414,7 +414,7 @@
 
 		static::$loaded[__METHOD__][$selector] = $opt;
 
-		return '<div id="' . $selector . '" class="accordion" role="tablist">';
+		return '<div id="' . $selector . '" class="accordion">';
 	}
 
 	/**
@@ -450,10 +450,10 @@
 		$class     = (!empty($class)) ? ' ' . $class : '';
 
 		$html = '<div class="card mb-2' . $class . '">'
-			. '<a href="#' . $id . '" data-toggle="collapse"' . $parent . ' class="card-header' . $collapsed . '" role="tab">'
+			. '<a href="#' . $id . '" data-toggle="collapse"' . $parent . ' class="card-header' . $collapsed . '" id="link-' . $id . '">'
 			. $text
 			. '</a>'
-			. '<div class="collapse' . $in . '" id="' . $id . '" role="tabpanel">'
+			. '<div class="collapse' . $in . '" id="' . $id . '" role="region"  aria-labelledby="link-' . $id . '">'
 			. '<div class="card-body">';
 
 		return $html;
avatar angieradtke angieradtke - open - 3 Jul 2020
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Jul 2020
avatar angieradtke angieradtke - change - 3 Jul 2020
Title
Bootstrap.php wrong aria usage accordion view
4.0 Bootstrap.php wrong aria usage accordion view
avatar angieradtke angieradtke - edited - 3 Jul 2020
avatar angieradtke angieradtke - change - 3 Jul 2020
Title
4.0 Bootstrap.php wrong aria usage accordion view
[4.0] Bootstrap.php wrong aria usage accordion view
avatar angieradtke angieradtke - edited - 3 Jul 2020
avatar Quy Quy - change - 3 Jul 2020
The description was changed
avatar Quy Quy - edited - 3 Jul 2020
avatar korenevskiy
korenevskiy - comment - 3 Jul 2020

@angieradtke Maybe J4 will be on Bootstrap 5

avatar Quy Quy - change - 29 Jul 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-07-29 16:44:37
Closed_By Quy
avatar Quy Quy - close - 29 Jul 2020
avatar Quy Quy - change - 4 Sep 2020
Status Closed New
Closed_Date 2020-07-29 16:44:37
Closed_By Quy
avatar Quy Quy - reopen - 4 Sep 2020
avatar brianteeman
brianteeman - comment - 6 Feb 2022

Should be closed as the code referred to doesnt exist

avatar alikon alikon - change - 13 Feb 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-02-13 10:58:10
Closed_By alikon
Labels Added: No Code Attached Yet
Removed: ?
avatar alikon alikon - close - 13 Feb 2022

Add a Comment

Login with GitHub to post a comment