What needs to be fixed
The accordion view is still using tab-aria syntax . This is wrong.
Why this should be fixed
Wrong usage , 1Ally
Suggestion: Anker can be a button but this leads to styling issues.
How would you fix it
Index: libraries/src/HTML/Helpers/Bootstrap.php
@@ -414,7 +414,7 @@
static::$loaded[__METHOD__][$selector] = $opt;
- return '<div id="' . $selector . '" class="accordion" role="tablist">';
+ return '<div id="' . $selector . '" class="accordion">';
}
/**
@@ -450,10 +450,10 @@
$class = (!empty($class)) ? ' ' . $class : '';
$html = '<div class="card mb-2' . $class . '">'
- . '<a href="#' . $id . '" data-toggle="collapse"' . $parent . ' class="card-header' . $collapsed . '" role="tab">'
+ . '<a href="#' . $id . '" data-toggle="collapse"' . $parent . ' class="card-header' . $collapsed . '" id="link-' . $id . '">'
. $text
. '</a>'
- . '<div class="collapse' . $in . '" id="' . $id . '" role="tabpanel">'
+ . '<div class="collapse' . $in . '" id="' . $id . '" role="region" aria-labelledby="link-' . $id . '">'
. '<div class="card-body">';
return $html;
@angieradtke Maybe J4 will be on Bootstrap 5