[#29920] - [4.0] [a11y] PR for #29909 rfc empty headings
- Fixed in Code Base
- 4 Jul 2020
- Medium
- Build: 4.0-dev
- # 29920
- Diff
- hans2103:origin/feature/4.0-RFC-empty-headings-a11y-#29909
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This PR adds a fallback value for heading when creating a new user.
Created for #29909
Testing Instructions
- Start creating a new user.
- View source and find the first heading in id=user-form
Actual result BEFORE applying this Pull Request
Before ... heading is empty
Expected result AFTER applying this Pull Request
After... heading is filled with text. Text is visible too,
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users Language & Strings |
Was just checking.
To match the style guide each word in the title string should be capitalized.
Calling it a night will check again in the morning
I have tested this item
The instructions might have said to look for id="user-form" and the empty h2 is in the next line. I guess the capitalisation is a just a minor string fix. For a user edit the h2 contains the user name which might be John Doe or just john.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29920.
To match the style guide each word in the title string should be capitalized.
@brianteeman can you point me where this is not the case?
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29920.
@hans2103 as an RFC I am marking this as success. Thanks.
Thinking afresh on the wording I am thinking it would be better to have a descriptive text instead of an action text. In other words "New User Details" instead of "Create....
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29920.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29920.
You do realise it's not just for com_users ?
I'm failing to find other components with this behaviour. The edit.php file from other components work differently.
<?php echo LayoutHelper::render('joomla.edit.title_alias', $this); ?>
administrator/index.php?option=com_languages&view=language&layout=edit
I'm sure I found more than that before but can't see any right now
please open a new issue for that..... in the meantime let me close this one
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-03 19:08:20 |
| Closed_By | ⇒ | alikon |
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-07-03 19:08:20 | ⇒ | |
| Closed_By | alikon | ⇒ |
| Status | New | ⇒ | Pending |
oops wrong one
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29920.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29920.
Quy
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-07-04 18:07:55 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
You do realise it's not just for com_users ?