? ? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
2 Jul 2020

Pull Request for Issue # #29896.

Summary of Changes

Change FontAwesome Icons

Testing Instructions

See #29896. I copied instructions form there.

  1. Install a clean 4.0-dev.
  2. When you get to the first screen which lets you Install Additional Languages, click to install a new language.
  3. Select French fr-FR or German de-DE and click Next button.
  4. In the next screen choose a default admin and site language and click on Set default language

-> No need for a chevron there, I removed it
PLEASE TEST THIS

  1. Then click again on Install Additional Languages button

-> The chevron should be left and placed before the text in LTR, the opposite in RTL. I implemented this PLEASE TEST THIS in German and Persion

avatar astridx astridx - open - 2 Jul 2020
avatar astridx astridx - change - 2 Jul 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jul 2020
Category Installation
avatar astridx astridx - change - 2 Jul 2020
Labels Added: ?
avatar infograf768
infograf768 - comment - 3 Jul 2020

@astridx
Maybe I did not express myself correctly. I do consider the chevron a back and forth indication.

After your patch for LTR
When we get to the first display of Install Additional Languages
I think we should keep the chevron after the text to indicate going to next page.
I.e. we should not do
Screen Shot 2020-07-03 at 10 01 43

but keep
Screen Shot 2020-07-03 at 10 17 51

But here, instead of this
Screen Shot 2020-07-03 at 10 08 04

We should have this to indicate that we go backward

Screen Shot 2020-07-03 at 10 11 35

Obvioulsy the opposite in RTL

avatar infograf768
infograf768 - comment - 3 Jul 2020

The main problem is to differentiate the 2 views..

avatar astridx
astridx - comment - 3 Jul 2020

I got it wrong. Where do you see exactly going back?

@infograf768 Obvioulsy the opposite in RTL

I just took a closer look at it. Is RTL used in the installation at all?
If I set Persian as the default, it's still LTR, right?

avatar infograf768
infograf768 - comment - 4 Jul 2020

I got it wrong. Where do you see exactly going back?

Once you have installed one language with Next, you get to the list of installed languages to select default.
Clicking again on Install Additional Languages is what I call "going back" as we get back to the list of all languages we can install.

I tested RTL by adding the 3.x fa-IR installation lang folder to J4 and choosing it as installation language. This is independent of the installation of the Persian language later on in the process.
It looks like we have issues with many icons (including the chevron but this case is explained above) which should display at the right of the text instead of left.

avatar astridx
astridx - comment - 4 Jul 2020

Clicking again on Install Additional Languages is what I call "going back" as we get back to the list of all languages we can install.

Hm. I think that's a matter of opinion. For me it is a new step forward.

I tested RTL by adding the 3.x fa-IR installation lang folder to J4 and choosing it as installation language. This is independent of the installation of the Persian language later on in the process.

If I looked right, then RTL is not used for the installation.

avatar astridx astridx - change - 4 Jul 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-07-04 07:03:26
Closed_By astridx
avatar astridx astridx - close - 4 Jul 2020
avatar infograf768
infograf768 - comment - 4 Jul 2020

RTL is used if the language for installation is set as rtl. Just add the J3 fa-IR installation lang folder and select it when installing.

Screen Shot 2020-07-04 at 09 30 33

and then

Screen Shot 2020-07-04 at 09 29 53

Screen Shot 2020-07-04 at 09 32 50

Screen Shot 2020-07-04 at 09 34 20

Only small hitch below: the "Complete & ..." icons are placed to the left, they should be to the right (not a release blocker)

Screen Shot 2020-07-04 at 09 35 03

This hitch can be solved by taking off this in the rtl template.scss

.j-install-last-step .fas {
  display: inline;
}

then we will get
Screen Shot 2020-07-04 at 10 13 11

avatar astridx astridx - change - 4 Jul 2020
Status Closed New
Closed_Date 2020-07-04 07:03:26
Closed_By astridx
avatar astridx astridx - change - 4 Jul 2020
Status New Pending
avatar astridx astridx - change - 4 Jul 2020
Status Pending Closed
avatar astridx astridx - reopen - 4 Jul 2020
8553704 4 Jul 2020 avatar astridx rtl
avatar astridx
astridx - comment - 4 Jul 2020

RTL is used if the language for installation is set as rtl. Just add the J3 fa-IR installation lang folder and select it when install

Thank you, I had only seen the two languages available and did not know that others would be added.
Is that how you imagine it to be?

جوملا نصب وب سایت
Joomla Installer(1)

(I didn't spin the arrow. I think that you always go forward to languages. After installing, you go back to the finished site. If you want to install more than one additional language you go forward again ...)

avatar infograf768
infograf768 - comment - 4 Jul 2020

@astridx
why not just delete the inline ?
.j-install-last-step .fas {
display: inline;
}

avatar astridx
astridx - comment - 17 Jul 2020

@astridx
why not just delete the inline ?
.j-install-last-step .fas {
display: inline;
}

Because I do not understand why this display: inline; was set and therefore do not want to delete it. I'm not sure if that will affect anything else. You also don't have to do npm ci like this for testing.

avatar astridx astridx - change - 1 Aug 2020
Labels Added: ?
avatar astridx astridx - close - 1 Aug 2020

Add a Comment

Login with GitHub to post a comment